OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Normalize the local app version (#20062) 

We need to strip the leading v from the local app version as well as the one fetched from the server
pull/20078/head
James Salter 2021-12-07 02:09:23 +11:00 committed by GitHub
parent b14b2967ec
commit 39901b8d72
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/vector/platform/WebPlatform.ts
View File

@ -128,7 +128,7 @@ export default class WebPlatform extends VectorBasePlatform {
});
}
getAppVersion(): Promise<string> {
getNormalizedAppVersion(): string {
let ver = process.env.VERSION;
// if version looks like semver with leading v, strip it
@ -137,7 +137,11 @@ export default class WebPlatform extends VectorBasePlatform {
if (semVerRegex.test(process.env.VERSION)) {
ver = process.env.VERSION.substr(1);
}
return Promise.resolve(ver);
return ver;
}
getAppVersion(): Promise<string> {
return Promise.resolve(this.getNormalizedAppVersion());
}
startUpdater() {
@ -151,9 +155,11 @@ export default class WebPlatform extends VectorBasePlatform {
pollForUpdate = () => {
return this.getMostRecentVersion().then((mostRecentVersion) => {
if (process.env.VERSION !== mostRecentVersion) {
const currentVersion = this.getNormalizedAppVersion();
if (currentVersion !== mostRecentVersion) {
if (this.shouldShowUpdate(mostRecentVersion)) {
showUpdateToast(process.env.VERSION, mostRecentVersion);
showUpdateToast(currentVersion, mostRecentVersion);
}
return { status: UpdateCheckStatus.Ready };
} else {