From 3bff5c55cfa34d8ac6405664330c84f93ff674d8 Mon Sep 17 00:00:00 2001 From: Marco Zehe Date: Tue, 10 Mar 2020 16:24:42 +0100 Subject: [PATCH] Remove extraneous tab stop from room tree view. This was introduced some time ago when the room list became scrollable. Divs with overflow:scroll; become focusable for the keyboard in Firefox, but since we have keyboard handling for the whole compound widget, we don't need that tab stop on the tree view container div. Putting tabindex="-1" on it fixes it. Signed-off-by: Marco Zehe --- src/components/views/rooms/RoomList.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/components/views/rooms/RoomList.js b/src/components/views/rooms/RoomList.js index ad67d8e308..0fe0ff3d8c 100644 --- a/src/components/views/rooms/RoomList.js +++ b/src/components/views/rooms/RoomList.js @@ -778,6 +778,9 @@ export default createReactClass({ className="mx_RoomList" role="tree" aria-label={_t("Rooms")} + // Firefox sometimes makes this element focusable due to + // overflow:scroll;, so force it out of tab order. + tabindex="-1" onMouseMove={this.onMouseMove} onMouseLeave={this.onMouseLeave} >