From 3c4d25d6c2cf6dde69300815000559561a816c50 Mon Sep 17 00:00:00 2001 From: Val Lorentz Date: Mon, 6 Mar 2023 13:04:42 +0100 Subject: [PATCH] package.json: Remove --host override (#24736) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Most people probably only want the dev server to listen on localhost. Additionally, overriding with `--host 0.0.0.0` here prevents passing a different value for `--host` to yarn. For example: ``` $ yarnpkg start:js --host=:: yarn run v1.22.19 $ webpack-dev-server --host=0.0.0.0 --output-filename=bundles/_dev_/[name].js --output-chunk-filename=bundles/_dev_/[name].js -w --mode development --disable-host-check --hot --host=:: Unset VERSION variable - this may affect build output ✖ ｢wds｣: webpack Dev Server Invalid Options options.host should be {String|Null} (https://webpack.js.org/configuration/dev-server/#devserverhost) error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ``` --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 6e47b489ec..c1dbce4a8b 100644 --- a/package.json +++ b/package.json @@ -44,7 +44,7 @@ "start": "yarn build:module_system && concurrently --kill-others-on-fail --prefix \"{time} [{name}]\" -n res,element-js \"yarn start:res\" \"yarn start:js\"", "start:https": "concurrently --kill-others-on-fail --prefix \"{time} [{name}]\" -n res,element-js \"yarn start:res\" \"yarn start:js --https\"", "start:res": "yarn build:jitsi && node scripts/copy-res.js -w", - "start:js": "webpack-dev-server --host=0.0.0.0 --output-filename=bundles/_dev_/[name].js --output-chunk-filename=bundles/_dev_/[name].js -w --mode development --disable-host-check --hot", + "start:js": "webpack-dev-server --output-filename=bundles/_dev_/[name].js --output-chunk-filename=bundles/_dev_/[name].js -w --mode development --disable-host-check --hot", "lint": "yarn lint:types && yarn lint:js && yarn lint:style", "lint:js": "yarn lint:js:src && yarn lint:js:module_system", "lint:js:src": "eslint --max-warnings 0 src test && prettier --check .",