OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix tooltip infinitely recursing (#9235)

t3chguy/dedup-icons-17oct
Michael Telatynski 2022-09-02 10:03:53 +01:00 committed by GitHub
parent d1237b2c98
commit 3e8da6ffa4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/components/views/elements/Tooltip.tsx
View File

@ -22,6 +22,7 @@ import ReactDOM from 'react-dom';
import classNames from 'classnames'; import classNames from 'classnames';
import UIStore from "../../../stores/UIStore"; import UIStore from "../../../stores/UIStore";
import { objectHasDiff } from "../../../utils/objects";
export enum Alignment { export enum Alignment {
Natural, // Pick left or right Natural, // Pick left or right
@ -91,8 +92,10 @@ export default class Tooltip extends React.PureComponent<ITooltipProps, State> {
this.updatePosition(); this.updatePosition();
} }
public componentDidUpdate() { public componentDidUpdate(prevProps) {
this.updatePosition(); if (objectHasDiff(prevProps, this.props)) {
this.updatePosition();
}
} }
// Remove the wrapper element, as the tooltip has finished using it // Remove the wrapper element, as the tooltip has finished using it