Merge pull request #2948 from matrix-org/jryans/quote-regression

Restore access to message quote option on first click
pull/21833/head
J. Ryan Stinnett 2019-05-07 12:56:37 +01:00 committed by GitHub
commit 406c9d5d21
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 5 deletions

View File

@ -28,8 +28,8 @@ export default class MessageActionBar extends React.PureComponent {
static propTypes = { static propTypes = {
mxEvent: PropTypes.object.isRequired, mxEvent: PropTypes.object.isRequired,
permalinkCreator: PropTypes.object, permalinkCreator: PropTypes.object,
tile: PropTypes.element, getTile: PropTypes.func,
replyThread: PropTypes.element, getReplyThread: PropTypes.func,
onFocusChange: PropTypes.func, onFocusChange: PropTypes.func,
}; };
@ -63,7 +63,9 @@ export default class MessageActionBar extends React.PureComponent {
const x = buttonRect.right + window.pageXOffset; const x = buttonRect.right + window.pageXOffset;
const y = (buttonRect.top + (buttonRect.height / 2) + window.pageYOffset) - 19; const y = (buttonRect.top + (buttonRect.height / 2) + window.pageYOffset) - 19;
const {tile, replyThread} = this.props; const { getTile, getReplyThread } = this.props;
const tile = getTile && getTile();
const replyThread = getReplyThread && getReplyThread();
let e2eInfoCallback = null; let e2eInfoCallback = null;
if (this.props.mxEvent.isEncrypted()) { if (this.props.mxEvent.isEncrypted()) {

View File

@ -464,6 +464,14 @@ module.exports = withMatrixClient(React.createClass({
}); });
}, },
getTile() {
return this.refs.tile;
},
getReplyThread() {
return this.refs.replyThread;
},
render: function() { render: function() {
const MessageTimestamp = sdk.getComponent('messages.MessageTimestamp'); const MessageTimestamp = sdk.getComponent('messages.MessageTimestamp');
const SenderProfile = sdk.getComponent('messages.SenderProfile'); const SenderProfile = sdk.getComponent('messages.SenderProfile');
@ -580,8 +588,8 @@ module.exports = withMatrixClient(React.createClass({
const actionBar = <MessageActionBar const actionBar = <MessageActionBar
mxEvent={this.props.mxEvent} mxEvent={this.props.mxEvent}
permalinkCreator={this.props.permalinkCreator} permalinkCreator={this.props.permalinkCreator}
tile={this.refs.tile} getTile={this.getTile}
replyThread={this.refs.replyThread} getReplyThread={this.getReplyThread}
onFocusChange={this.onActionBarFocusChange} onFocusChange={this.onActionBarFocusChange}
/>; />;