From 41be46a7120075b5792194bcdf2c56f6e9b240fa Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Wed, 13 Jun 2018 09:51:35 +0100 Subject: [PATCH] apply roomlist searchFilter to aliases if it begins with a `#` Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- src/components/structures/RoomSubList.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/components/structures/RoomSubList.js b/src/components/structures/RoomSubList.js index fb82ee067b..17daa8553b 100644 --- a/src/components/structures/RoomSubList.js +++ b/src/components/structures/RoomSubList.js @@ -105,8 +105,15 @@ var RoomSubList = React.createClass({ applySearchFilter: function(list, filter) { if (filter === "") return list; + const lcFilter = filter.toLowerCase(); return list.filter((room) => { - return room.name && room.name.toLowerCase().indexOf(filter.toLowerCase()) >= 0 + if (room.name && room.name.toLowerCase().includes(lcFilter)) return true; + // only apply search filter to aliases if it looks like an alias (starts with `#`) + // to prevent loads of false positives with server names, e.g `matrix` + if (filter[0] === '#' && room.getAliases().some((alias) => { + return alias.toLowerCase().startsWith(lcFilter); + })) return true; + return false; }); },