From 0a638cd5458b17e81f210d5f2b50551b74953a55 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Sun, 1 Jul 2018 23:48:00 +0100 Subject: [PATCH] move nag bar clear statement to any desktop notif toggle not just 0->1 Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- src/Notifier.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Notifier.js b/src/Notifier.js index b823c4df05..80e8be1084 100644 --- a/src/Notifier.js +++ b/src/Notifier.js @@ -170,15 +170,15 @@ const Notifier = { value: true, }); }); - // clear the notifications_hidden flag, so that if notifications are - // disabled again in the future, we will show the banner again. - this.setToolbarHidden(true); } else { dis.dispatch({ action: "notifier_enabled", value: false, }); } + // set the notifications_hidden flag, as the user has knowingly interacted + // with the setting we shouldn't nag them any further + this.setToolbarHidden(true); }, isEnabled: function() {