OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #3564 from t3chguy/t3chguy/malformed-notifications-gnome-kde 

Escape HTML Tags from Linux Notifications (electron)
pull/3272/merge
Matthew Hodgson 2017-04-22 16:45:04 +01:00 committed by GitHub
parent 8a6283fedf 0da6ca8aea
commit 4864716abb
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/vector/platform/ElectronPlatform.js
View File

@ -81,6 +81,17 @@ export default class ElectronPlatform extends VectorBasePlatform {
}
displayNotification(title: string, msg: string, avatarUrl: string, room: Object): Notification {
// GNOME notification spec parses HTML tags for styling...
// Electron Docs state all supported linux notification systems follow this markup spec
// https://github.com/electron/electron/blob/master/docs/tutorial/desktop-environment-integration.md#linux
// maybe we should pass basic styling (italics, bold, underline) through from MD
// we only have to strip out < and > as the spec doesn't include anything about things like &amp;
// so we shouldn't assume that all implementations will treat those properly. Very basic tag parsing is done.
if (window.process.platform === 'linux') {
msg = msg.replace(/</g, "&lt;").replace(/>/g, "&gt;");
}
// Notifications in Electron use the HTML5 notification API
const notification = new global.Notification(
title,