OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix freeze/crash when 1:1 calling (#8057) (#8058) 

* Fix freeze/crash when 1:1 calling

Don't log call feed objects because they reference the client and
it causes the client to get logged too.

* Log purpose too
pull/21833/head
David Baker 2022-03-15 14:06:22 +00:00 committed by GitHub
parent e485907443
commit 4d6643c7b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/components/views/voip/AudioFeed.tsx
View File

@ -93,7 +93,10 @@ export default class AudioFeed extends React.Component<IProps, IState> {
// load() explicitly, it shouldn't be a problem. - Dave // load() explicitly, it shouldn't be a problem. - Dave
await element.load(); await element.load();
} catch (e) { } catch (e) {
logger.info("Failed to play media element with feed", this.props.feed, e); logger.info(
`Failed to play media element with feed for userId ` +
`${this.props.feed.userId} with purpose ${this.props.feed.purpose}`, e,
);
} }
} }

5
src/components/views/voip/VideoFeed.tsx
View File

@ -138,7 +138,10 @@ export default class VideoFeed extends React.PureComponent<IProps, IState> {
// load() explicitly, it shouldn't be a problem. - Dave // load() explicitly, it shouldn't be a problem. - Dave
await element.play(); await element.play();
} catch (e) { } catch (e) {
logger.info("Failed to play media element with feed", this.props.feed, e); logger.info(
`Failed to play media element with feed for userId ` +
`${this.props.feed.userId} with purpose ${this.props.feed.purpose}`, e,
);
} }
} }