From 54d85a3864b8d8fedd7da859df8768c3f77f9c8f Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Wed, 11 Aug 2021 16:32:48 +0100 Subject: [PATCH] Iterate PR based on feedback --- res/css/views/dialogs/_CreateSpaceFromCommunityDialog.scss | 4 ++++ .../views/dialogs/CreateSpaceFromCommunityDialog.tsx | 5 +++-- src/components/views/spaces/SpaceCreateMenu.tsx | 4 ++-- src/i18n/strings/en_EN.json | 5 +++-- 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/res/css/views/dialogs/_CreateSpaceFromCommunityDialog.scss b/res/css/views/dialogs/_CreateSpaceFromCommunityDialog.scss index b011fb104a..306fc77011 100644 --- a/res/css/views/dialogs/_CreateSpaceFromCommunityDialog.scss +++ b/res/css/views/dialogs/_CreateSpaceFromCommunityDialog.scss @@ -50,6 +50,10 @@ limitations under the License. line-height: $font-15px; margin: 16px 0; } + + .mx_Field_textarea { + margin-bottom: 0; + } } .mx_JoinRuleDropdown .mx_Dropdown_menu { diff --git a/src/components/views/dialogs/CreateSpaceFromCommunityDialog.tsx b/src/components/views/dialogs/CreateSpaceFromCommunityDialog.tsx index 335be80a70..c9e13d2b61 100644 --- a/src/components/views/dialogs/CreateSpaceFromCommunityDialog.tsx +++ b/src/components/views/dialogs/CreateSpaceFromCommunityDialog.tsx @@ -288,8 +288,9 @@ const CreateSpaceFromCommunityDialog: React.FC = ({ matrixClient: cli, g

{ _t("Spaces are the new version of communities - with new features coming.") }   - { _t("All rooms will automatically be added, a link to the Space will be " + - "added to your old community description and all community members will be invited.") } + { _t("A link to the Space will be put in your community description.") } +   + { _t("All rooms will be added and all community members will be invited.") }

{ _t("Flair won't be available in Spaces for the foreseeable future.") } diff --git a/src/components/views/spaces/SpaceCreateMenu.tsx b/src/components/views/spaces/SpaceCreateMenu.tsx index 9921194b39..33e4a990ef 100644 --- a/src/components/views/spaces/SpaceCreateMenu.tsx +++ b/src/components/views/spaces/SpaceCreateMenu.tsx @@ -285,8 +285,8 @@ const SpaceCreateMenu = ({ onFinished }) => { { sub } , }) } -   - { _t("To join an existing space you'll need an invite") } +
+ { _t("To join an existing space you'll need an invite.") }

diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index f41a0dccc2..3b5a748f89 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -1034,7 +1034,7 @@ "Private": "Private", "Invite only, best for yourself or teams": "Invite only, best for yourself or teams", "You can also create a Space from a community.": "You can also create a Space from a community.", - "To join an existing space you'll need an invite": "To join an existing space you'll need an invite", + "To join an existing space you'll need an invite.": "To join an existing space you'll need an invite.", "Go back": "Go back", "Your public space": "Your public space", "Your private space": "Your private space", @@ -2238,7 +2238,8 @@ "Failed to migrate community": "Failed to migrate community", "Create Space from community": "Create Space from community", "Spaces are the new version of communities - with new features coming.": "Spaces are the new version of communities - with new features coming.", - "All rooms will automatically be added, a link to the Space will be added to your old community description and all community members will be invited.": "All rooms will automatically be added, a link to the Space will be added to your old community description and all community members will be invited.", + "A link to the Space will be put in your community description.": "A link to the Space will be put in your community description.", + "All rooms will be added and all community members will be invited.": "All rooms will be added and all community members will be invited.", "Flair won't be available in Spaces for the foreseeable future.": "Flair won't be available in Spaces for the foreseeable future.", "This description will be shown to people when they view your space": "This description will be shown to people when they view your space", "Space visibility": "Space visibility",