OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix dropdown keyboard accessibility when filter is disabled

pull/21833/head
Michael Telatynski 2021-08-06 14:21:41 +01:00
parent 41475a3b94
commit 54fb24f359
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/components/views/elements/Dropdown.tsx
View File

@ -204,7 +204,7 @@ export default class Dropdown extends React.Component<IProps, IState> {
this.props.onOptionChange(dropdownKey); this.props.onOptionChange(dropdownKey);
}; };
private onInputKeyDown = (e: React.KeyboardEvent) => { private onKeyDown = (e: React.KeyboardEvent) => {
let handled = true; let handled = true;
// These keys don't generate keypress events and so needs to be on keyup // These keys don't generate keypress events and so needs to be on keyup
@ -320,7 +320,6 @@ export default class Dropdown extends React.Component<IProps, IState> {
type="text" type="text"
autoFocus={true} autoFocus={true}
className="mx_Dropdown_option" className="mx_Dropdown_option"
onKeyDown={this.onInputKeyDown}
onChange={this.onInputChange} onChange={this.onInputChange}
value={this.state.searchQuery} value={this.state.searchQuery}
role="combobox" role="combobox"
@ -358,7 +357,7 @@ export default class Dropdown extends React.Component<IProps, IState> {
// Note the menu sits inside the AccessibleButton div so it's anchored // Note the menu sits inside the AccessibleButton div so it's anchored
// to the input, but overflows below it. The root contains both. // to the input, but overflows below it. The root contains both.
return <div className={classnames(dropdownClasses)} ref={this.collectRoot}> return <div className={classnames(dropdownClasses)} ref={this.collectRoot} onKeyDown={this.onKeyDown}>
<AccessibleButton <AccessibleButton
className="mx_Dropdown_input mx_no_textinput" className="mx_Dropdown_input mx_no_textinput"
onClick={this.onInputClick} onClick={this.onInputClick}