From 558a6204f1b2130cacd3a05ead1c9de32a6c2990 Mon Sep 17 00:00:00 2001 From: Timo <16718859+toger5@users.noreply.github.com> Date: Thu, 4 Nov 2021 11:36:20 +0100 Subject: [PATCH] Fix possible infinite loop on widget start (#7071) * fix 15494 infinit loop on widget start error * change message to error from log and fix block style --- src/components/views/elements/AppTile.tsx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/components/views/elements/AppTile.tsx b/src/components/views/elements/AppTile.tsx index d8a29e81fc..dcb6e62649 100644 --- a/src/components/views/elements/AppTile.tsx +++ b/src/components/views/elements/AppTile.tsx @@ -227,7 +227,7 @@ export default class AppTile extends React.Component { this.sgWidget.on("ready", this.onWidgetReady); this.startWidget(); } catch (e) { - logger.log("Failed to construct widget", e); + logger.error("Failed to construct widget", e); this.sgWidget = null; } } @@ -241,7 +241,13 @@ export default class AppTile extends React.Component { private iframeRefChange = (ref: HTMLIFrameElement): void => { this.iframe = ref; if (ref) { - if (this.sgWidget) this.sgWidget.start(ref); + try { + if (this.sgWidget) { + this.sgWidget.start(ref); + } + } catch (e) { + logger.error("Failed to start widget", e); + } } else { this.resetWidget(this.props); }