OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix voice broadcast recording (#9617)

pull/28788/head^2
Michael Weimann 2022-11-25 08:47:46 +01:00 committed by GitHub
parent d71a72e27c
commit 55921e4888
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 35 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/voice-broadcast/audio/VoiceBroadcastRecorder.ts
View File

@ -80,6 +80,7 @@ export class VoiceBroadcastRecorder
const chunk = this.extractChunk();
this.currentChunkLength = 0;
this.previousChunkEndTimePosition = 0;
this.headers = new Uint8Array(0);
return chunk;
}

51
test/voice-broadcast/audio/VoiceBroadcastRecorder-test.ts
View File

@ -76,8 +76,27 @@ describe("VoiceBroadcastRecorder", () => {
let voiceBroadcastRecorder: VoiceBroadcastRecorder;
let onChunkRecorded: (chunk: ChunkRecordedPayload) => void;
const itShouldNotEmitAChunkRecordedEvent = () => {
it("should not emit a ChunkRecorded event", () => {
const simulateFirstChunk = (): void => {
voiceRecording.onDataAvailable(headers1);
voiceRecording.onDataAvailable(headers2);
// set recorder seconds to something greater than the test chunk length of 30
// @ts-ignore
voiceRecording.recorderSeconds = 42;
voiceRecording.onDataAvailable(chunk1);
};
const expectOnFirstChunkRecorded = (): void => {
expect(onChunkRecorded).toHaveBeenNthCalledWith(
1,
{
buffer: concat(headers1, headers2, chunk1),
length: 42,
},
);
};
const itShouldNotEmitAChunkRecordedEvent = (): void => {
it("should not emit a ChunkRecorded event", (): void => {
expect(voiceRecording.emit).not.toHaveBeenCalledWith(
VoiceBroadcastRecorderEvent.ChunkRecorded,
expect.anything(),
@ -163,7 +182,7 @@ describe("VoiceBroadcastRecorder", () => {
itShouldNotEmitAChunkRecordedEvent();
describe("stop", () => {
describe("and calling stop", () => {
let stopPayload: ChunkRecordedPayload;
beforeEach(async () => {
@ -176,18 +195,22 @@ describe("VoiceBroadcastRecorder", () => {
length: 23,
});
});
describe("and calling start again and receiving some data", () => {
beforeEach(() => {
simulateFirstChunk();
});
it("should emit the ChunkRecorded event for the first chunk", () => {
expectOnFirstChunkRecorded();
});
});
});
});
describe("when some chunks have been received", () => {
beforeEach(() => {
// simulate first chunk
voiceRecording.onDataAvailable(headers1);
voiceRecording.onDataAvailable(headers2);
// set recorder seconds to something greater than the test chunk length of 30
// @ts-ignore
voiceRecording.recorderSeconds = 42;
voiceRecording.onDataAvailable(chunk1);
simulateFirstChunk();
// simulate a second chunk
voiceRecording.onDataAvailable(chunk2a);
@ -198,13 +221,7 @@ describe("VoiceBroadcastRecorder", () => {
});
it("should emit ChunkRecorded events", () => {
expect(onChunkRecorded).toHaveBeenNthCalledWith(
1,
{
buffer: concat(headers1, headers2, chunk1),
length: 42,
},
);
expectOnFirstChunkRecorded();
expect(onChunkRecorded).toHaveBeenNthCalledWith(
2,