OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Stick a couple micro optimizations into the setRoomCategory hot path

pull/21833/head
Travis Ralston 2019-02-19 14:56:56 -07:00
parent 7b732ceb43
commit 561d1f37ec
1 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/stores/RoomListStore.js
View File

@ -231,14 +231,15 @@ class RoomListStore extends Store {
} }
_roomUpdateTriggered(roomId) { _roomUpdateTriggered(roomId) {
const room = this._matrixClient.getRoom(roomId);
if (!room) return;
// We don't calculate categories for sticky rooms because we have a moderate // We don't calculate categories for sticky rooms because we have a moderate
// interest in trying to maintain the category that they were last in before // interest in trying to maintain the category that they were last in before
// being artificially flagged as IDLE. Also, this reduces the amount of time // being artificially flagged as IDLE. Also, this reduces the amount of time
// we spend in _setRoomCategory ever so slightly. // we spend in _setRoomCategory ever so slightly.
if (this._state.stickyRoomId !== room.roomId) { if (this._state.stickyRoomId !== roomId) {
// Micro optimization: Only look up the room if we're confident we'll need it.
const room = this._matrixClient.getRoom(roomId);
if (!room) return;
const category = this._calculateCategory(room); const category = this._calculateCategory(room);
this._setRoomCategory(room, category); this._setRoomCategory(room, category);
} }
@ -249,7 +250,15 @@ class RoomListStore extends Store {
const listsClone = {}; const listsClone = {};
const targetCategoryIndex = CATEGORY_ORDER.indexOf(category); const targetCategoryIndex = CATEGORY_ORDER.indexOf(category);
const targetTimestamp = this._tsOfNewestEvent(room);
// Micro optimization: Support lazily loading the last timestamp in a room
let _targetTimestamp = null;
const targetTimestamp = () => {
if (_targetTimestamp === null) {
_targetTimestamp = this._tsOfNewestEvent(room);
}
return _targetTimestamp;
};
const myMembership = room.getMyMembership(); const myMembership = room.getMyMembership();
let doInsert = true; let doInsert = true;
@ -290,7 +299,15 @@ class RoomListStore extends Store {
if (LIST_ORDERS[key] === 'recent' && hasRoom && entry.room.roomId !== this._state.stickyRoomId) { if (LIST_ORDERS[key] === 'recent' && hasRoom && entry.room.roomId !== this._state.stickyRoomId) {
const inTag = targetTags.length === 0 || targetTags.includes(key); const inTag = targetTags.length === 0 || targetTags.includes(key);
if (!pushedEntry && doInsert && inTag) { if (!pushedEntry && doInsert && inTag) {
const entryTimestamp = this._tsOfNewestEvent(entry.room); // Micro optimization: Support lazily loading the last timestamp in a room
let _entryTimestamp = null;
const entryTimestamp = () => {
if (_entryTimestamp === null) {
_entryTimestamp = this._tsOfNewestEvent(entry.room);
}
return _entryTimestamp;
};
const entryCategoryIndex = CATEGORY_ORDER.indexOf(entry.category); const entryCategoryIndex = CATEGORY_ORDER.indexOf(entry.category);
// As per above, check if we're meeting that boundary we wanted to locate. // As per above, check if we're meeting that boundary we wanted to locate.
@ -304,7 +321,7 @@ class RoomListStore extends Store {
// based on most recent timestamp. // based on most recent timestamp.
const changedBoundary = entryCategoryIndex > targetCategoryIndex; const changedBoundary = entryCategoryIndex > targetCategoryIndex;
const currentCategory = entryCategoryIndex === targetCategoryIndex; const currentCategory = entryCategoryIndex === targetCategoryIndex;
if (changedBoundary || (currentCategory && targetTimestamp >= entryTimestamp)) { if (changedBoundary || (currentCategory && targetTimestamp() >= entryTimestamp())) {
if (changedBoundary) { if (changedBoundary) {
// If we changed a boundary, then we've gone too far - go to the top of the last // If we changed a boundary, then we've gone too far - go to the top of the last
// section instead. // section instead.