Ensure notification badges stop listening when they unmount

2020-07-24 13:59:09 -06:00 · 2020-07-24 13:59:09 -06:00 · 593b472e50
parent fbdbbce529
commit 593b472e50
1 changed files with 3 additions and 0 deletions
--- a/src/components/views/rooms/NotificationBadge.tsx
+++ b/src/components/views/rooms/NotificationBadge.tsx
@ -72,6 +72,9 @@ export default class NotificationBadge extends React.PureComponent<XOR<IProps, I

    public componentWillUnmount() {
        SettingsStore.unwatchSetting(this.countWatcherRef);
+        if (this.props.notification) {
+            this.props.notification.off(NOTIFICATION_STATE_UPDATE, this.onNotificationUpdate);
+        }
    }

    public componentDidUpdate(prevProps: Readonly<IProps>) {