OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Ensure we always set some value in Field 

Always set some value on the Field's input so that it doesn't flip flop between
controlled and uncontrolled.
pull/21833/head
J. Ryan Stinnett 2019-03-07 16:41:44 +00:00
parent ea050683bd
commit 5a648ecfe4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/views/elements/Field.js
View File

@ -88,8 +88,8 @@ export default class Field extends React.PureComponent {
inputProps.onChange = this.onChange; inputProps.onChange = this.onChange;
// make sure we use the current `value` for the field and not the original one // make sure we use the current `value` for the field and not the original one
if (this.value != undefined) { if (inputProps.value === undefined) {
inputProps.value = this.value; inputProps.value = this.value || "";
} }
const fieldInput = React.createElement(inputElement, inputProps, children); const fieldInput = React.createElement(inputElement, inputProps, children);