OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #2631 from matrix-org/bwindels/roomlistfilterfix 

update range when items size changes
pull/21833/head
Bruno Windels 2019-02-13 20:29:40 +01:00 committed by GitHub
parent 0ad9d71935 a1a82e48d9
commit 5aa08a0f02
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/components/views/elements/LazyRenderList.js
View File

@ -62,8 +62,13 @@ export default class LazyRenderList extends React.Component {
componentWillReceiveProps(props) { componentWillReceiveProps(props) {
const state = this.state; const state = this.state;
const range = LazyRenderList.getVisibleRangeFromProps(props); const range = LazyRenderList.getVisibleRangeFromProps(props);
// only update state if the new range isn't contained by the old anymore const intersectRange = range.expand(OVERFLOW_MARGIN);
if (!state.renderRange || !state.renderRange.contains(range.expand(OVERFLOW_MARGIN))) {
const prevSize = this.props.items ? this.props.items.length : 0;
const listHasChangedSize = props.items.length !== prevSize;
// only update renderRange if the list has shrunk/grown and we need to adjust padding or
// if the new range isn't contained by the old anymore
if (listHasChangedSize || !state.renderRange || !state.renderRange.contains(intersectRange)) {
this.setState({renderRange: range.expand(OVERFLOW_ITEMS)}); this.setState({renderRange: range.expand(OVERFLOW_ITEMS)});
} }
} }