From 5e9368e794eac546569d93ae2738bd24566cdc74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20V=C3=A1gner?= Date: Mon, 12 Feb 2018 21:13:53 +0100 Subject: [PATCH] Add comments explaining our non standard usage of aria-described-by --- src/components/views/dialogs/BaseDialog.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/components/views/dialogs/BaseDialog.js b/src/components/views/dialogs/BaseDialog.js index 08fd972621..053aef66c3 100644 --- a/src/components/views/dialogs/BaseDialog.js +++ b/src/components/views/dialogs/BaseDialog.js @@ -76,6 +76,12 @@ export default React.createClass({ className={this.props.className} role="dialog" aria-labelledby='mx_BaseDialog_title' + // This should point to a node describing the dialog. + // If we were about to completelly follow this recommendation we'd need to + // make all the components relying on BaseDialog to be aware of it. + // So instead we will use the whole content as the description. + // Description comes first and if the content contains more text, + // AT users can skip its presentation. aria-describedby={this.props.contentId} >