From 5553e40f0c046baaf0e78578e02d7c8e32d48156 Mon Sep 17 00:00:00 2001 From: Dariusz Niemczyk Date: Thu, 19 Aug 2021 06:42:10 +0200 Subject: [PATCH 1/3] Fix AppTile.js indent --- src/components/views/elements/AppTile.js | 40 ++++++++++++------------ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/components/views/elements/AppTile.js b/src/components/views/elements/AppTile.js index 74ef178066..1950454f56 100644 --- a/src/components/views/elements/AppTile.js +++ b/src/components/views/elements/AppTile.js @@ -333,7 +333,7 @@ export default class AppTile extends React.Component { // this would only be for content hosted on the same origin as the element client: anything // hosted on the same origin as the client will get the same access as if you clicked // a link to it. - const sandboxFlags = "allow-forms allow-popups allow-popups-to-escape-sandbox "+ + const sandboxFlags = "allow-forms allow-popups allow-popups-to-escape-sandbox " + "allow-same-origin allow-scripts allow-presentation"; // Additional iframe feature pemissions @@ -443,25 +443,25 @@ export default class AppTile extends React.Component { return
{ this.props.showMenubar && -
- - { this.props.showTitle && this._getTileTitle() } - - - { this.props.showPopout && } - - -
} +
+ + { this.props.showTitle && this._getTileTitle() } + + + { this.props.showPopout && } + + +
} { appTileBody }
From c8e4e761008ae36d4aa21a6f0343e86efebf85ec Mon Sep 17 00:00:00 2001 From: Dariusz Niemczyk Date: Thu, 19 Aug 2021 06:42:38 +0200 Subject: [PATCH 2/3] Properly remove persistentWidget from WidgetStore Fixes #17226 --- src/components/views/elements/AppTile.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/views/elements/AppTile.js b/src/components/views/elements/AppTile.js index 1950454f56..74535f8fe3 100644 --- a/src/components/views/elements/AppTile.js +++ b/src/components/views/elements/AppTile.js @@ -218,6 +218,7 @@ export default class AppTile extends React.Component { // Delete the widget from the persisted store for good measure. PersistedElement.destroyElement(this._persistKey); + ActiveWidgetStore.destroyPersistentWidget(this.props.app.id); if (this._sgWidget) this._sgWidget.stop({ forceDestroy: true }); } From 595ba7f59d80044abdb15e73b74ceefa468a5405 Mon Sep 17 00:00:00 2001 From: Dariusz Niemczyk Date: Thu, 19 Aug 2021 06:43:12 +0200 Subject: [PATCH 3/3] Remove useless setState --- src/components/views/elements/AppTile.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/views/elements/AppTile.js b/src/components/views/elements/AppTile.js index 74535f8fe3..a02465d01e 100644 --- a/src/components/views/elements/AppTile.js +++ b/src/components/views/elements/AppTile.js @@ -308,7 +308,6 @@ export default class AppTile extends React.Component { if (this.iframe) { // Reload iframe this.iframe.src = this._sgWidget.embedUrl; - this.setState({}); } }); }