From 6106b3ce44122fc858f44eeec5bbbfc141a59286 Mon Sep 17 00:00:00 2001 From: lukebarnard Date: Fri, 19 Jan 2018 14:12:21 +0000 Subject: [PATCH] newOrder defaults `null`, allows check for `newOrder` on line 357 --- src/components/views/rooms/RoomList.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/views/rooms/RoomList.js b/src/components/views/rooms/RoomList.js index 85b4b52380..ca1fccd1f5 100644 --- a/src/components/views/rooms/RoomList.js +++ b/src/components/views/rooms/RoomList.js @@ -310,7 +310,7 @@ module.exports = React.createClass({ const hasChangedSubLists = result.source.droppableId !== result.destination.droppableId; - const newOrder = {}; + let newOrder = null; // Is the tag ordered manually? if (newTag && !newTag.match(/^(m\.lowpriority|im\.vector\.fake\.(invite|recent|direct|archived))$/)) { @@ -327,7 +327,9 @@ module.exports = React.createClass({ const nextOrder = newIndex === newList.length ? 1 : newList[offset + newIndex].tags[newTag].order; - newOrder['order'] = (prevOrder + nextOrder) / 2.0; + newOrder = { + order: (prevOrder + nextOrder) / 2.0, + }; } // More evilness: We will still be dealing with moving to favourites/low prio,