Update to use more strict rules for suppressing

Signed-off-by: Marco Zehe <marco@marcozehe.de>
pull/21833/head
Marco Zehe 2020-07-15 19:02:00 +02:00
parent d8373576f8
commit 636b0236b6
1 changed files with 5 additions and 6 deletions

View File

@ -686,8 +686,7 @@ export default createReactClass({
}); });
// If the tile is in the Sending state, don't speak the message. // If the tile is in the Sending state, don't speak the message.
const ariaLive = (isSending) ? "off" : undefined; const ariaLive = (this.props.eventSendStatus !== null) ? 'off' : undefined;
const ariaBusy = (isSending) ? "true" : undefined;
let permalink = "#"; let permalink = "#";
if (this.props.permalinkCreator) { if (this.props.permalinkCreator) {
@ -823,7 +822,7 @@ export default createReactClass({
case 'notif': { case 'notif': {
const room = this.context.getRoom(this.props.mxEvent.getRoomId()); const room = this.context.getRoom(this.props.mxEvent.getRoomId());
return ( return (
<div className={classes} aria-live={ariaLive} aria-busy={ariaBusy}> <div className={classes} aria-live={ariaLive}>
<div className="mx_EventTile_roomName"> <div className="mx_EventTile_roomName">
<a href={permalink} onClick={this.onPermalinkClicked}> <a href={permalink} onClick={this.onPermalinkClicked}>
{ room ? room.name : '' } { room ? room.name : '' }
@ -849,7 +848,7 @@ export default createReactClass({
} }
case 'file_grid': { case 'file_grid': {
return ( return (
<div className={classes} aria-live={ariaLive} aria-busy={ariaBusy}> <div className={classes} aria-live={ariaLive}>
<div className="mx_EventTile_line"> <div className="mx_EventTile_line">
<EventTileType ref={this._tile} <EventTileType ref={this._tile}
mxEvent={this.props.mxEvent} mxEvent={this.props.mxEvent}
@ -885,7 +884,7 @@ export default createReactClass({
); );
} }
return ( return (
<div className={classes} aria-live={ariaLive} aria-busy={ariaBusy}> <div className={classes} aria-live={ariaLive}>
{ ircTimestamp } { ircTimestamp }
{ avatar } { avatar }
{ sender } { sender }
@ -915,7 +914,7 @@ export default createReactClass({
// tab-index=-1 to allow it to be focusable but do not add tab stop for it, primarily for screen readers // tab-index=-1 to allow it to be focusable but do not add tab stop for it, primarily for screen readers
return ( return (
<div className={classes} tabIndex={-1} aria-live={ariaLive} aria-busy={ariaBusy}> <div className={classes} tabIndex={-1} aria-live={ariaLive}>
{ ircTimestamp } { ircTimestamp }
<div className="mx_EventTile_msgOption"> <div className="mx_EventTile_msgOption">
{ readAvatars } { readAvatars }