From 6407cd4c0d2cdfd54e2f9c83bbace166f82bc763 Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Thu, 25 Aug 2022 12:08:52 +0100
Subject: [PATCH] Reuse empty string & space string logic for event types in
 devtools (#9218)

* Reuse empty string & space string logic for event types in devtools

* Fix edge case behaviours

* Make tsc quality higher

* Make remainder of tsc happy
---
 .../views/dialogs/devtools/RoomState.tsx      | 75 +++++++++----------
 1 file changed, 37 insertions(+), 38 deletions(-)

diff --git a/src/components/views/dialogs/devtools/RoomState.tsx b/src/components/views/dialogs/devtools/RoomState.tsx
index d8a6fc0408..4ad4a1c821 100644
--- a/src/components/views/dialogs/devtools/RoomState.tsx
+++ b/src/components/views/dialogs/devtools/RoomState.tsx
@@ -41,6 +41,25 @@ export const StateEventEditor = ({ mxEvent, onBack }: IEditorProps) => {
     return <EventEditor fieldDefs={fields} defaultContent={defaultContent} onSend={onSend} onBack={onBack} />;
 };
 
+interface StateEventButtonProps {
+    label: string;
+    onClick(): void;
+}
+
+const StateEventButton = ({ label, onClick }: StateEventButtonProps) => {
+    const trimmed = label.trim();
+
+    return <button
+        className={classNames("mx_DevTools_button", {
+            mx_DevTools_RoomStateExplorer_button_hasSpaces: trimmed.length !== label.length,
+            mx_DevTools_RoomStateExplorer_button_emptyString: !trimmed,
+        })}
+        onClick={onClick}
+    >
+        { trimmed ? label : _t("<%(count)s spaces>", { count: label.length }) }
+    </button>;
+};
+
 interface IEventTypeProps extends Pick<IDevtoolsProps, "onBack"> {
     eventType: string;
 }
@@ -48,45 +67,35 @@ interface IEventTypeProps extends Pick<IDevtoolsProps, "onBack"> {
 const RoomStateExplorerEventType = ({ eventType, onBack }: IEventTypeProps) => {
     const context = useContext(DevtoolsContext);
     const [query, setQuery] = useState("");
-    const [event, setEvent] = useState<MatrixEvent>(null);
+    const [event, setEvent] = useState<MatrixEvent | null>(null);
 
-    const events = context.room.currentState.events.get(eventType);
+    const events = context.room.currentState.events.get(eventType)!;
 
     useEffect(() => {
         if (events.size === 1 && events.has("")) {
-            setEvent(events.get(""));
+            setEvent(events.get("")!);
         } else {
             setEvent(null);
         }
     }, [events]);
 
     if (event) {
-        const onBack = () => {
-            setEvent(null);
+        const _onBack = () => {
+            if (events?.size === 1 && events.has("")) {
+                onBack();
+            } else {
+                setEvent(null);
+            }
         };
-        return <EventViewer mxEvent={event} onBack={onBack} Editor={StateEventEditor} />;
+        return <EventViewer mxEvent={event} onBack={_onBack} Editor={StateEventEditor} />;
     }
 
     return <BaseTool onBack={onBack}>
         <FilteredList query={query} onChange={setQuery}>
             {
-                Array.from(events.entries()).map(([stateKey, ev]) => {
-                    const trimmed = stateKey.trim();
-                    const onClick = () => {
-                        setEvent(ev);
-                    };
-
-                    return <button
-                        className={classNames("mx_DevTools_button", {
-                            mx_DevTools_RoomStateExplorer_button_hasSpaces: trimmed.length !== stateKey.length,
-                            mx_DevTools_RoomStateExplorer_button_emptyString: !trimmed,
-                        })}
-                        key={stateKey}
-                        onClick={onClick}
-                    >
-                        { trimmed ? stateKey : _t("<%(count)s spaces>", { count: stateKey.length }) }
-                    </button>;
-                })
+                Array.from(events.entries()).map(([stateKey, ev]) => (
+                    <StateEventButton key={stateKey} label={stateKey} onClick={() => setEvent(ev)} />
+                ))
             }
         </FilteredList>
     </BaseTool>;
@@ -95,11 +104,11 @@ const RoomStateExplorerEventType = ({ eventType, onBack }: IEventTypeProps) => {
 export const RoomStateExplorer = ({ onBack, setTool }: IDevtoolsProps) => {
     const context = useContext(DevtoolsContext);
     const [query, setQuery] = useState("");
-    const [eventType, setEventType] = useState<string>(null);
+    const [eventType, setEventType] = useState<string | null>(null);
 
     const events = context.room.currentState.events;
 
-    if (eventType) {
+    if (eventType !== null) {
         const onBack = () => {
             setEventType(null);
         };
@@ -113,19 +122,9 @@ export const RoomStateExplorer = ({ onBack, setTool }: IDevtoolsProps) => {
     return <BaseTool onBack={onBack} actionLabel={_t("Send custom state event")} onAction={onAction}>
         <FilteredList query={query} onChange={setQuery}>
             {
-                Array.from(events.keys()).map((eventType) => {
-                    const onClick = () => {
-                        setEventType(eventType);
-                    };
-
-                    return <button
-                        className="mx_DevTools_button"
-                        key={eventType}
-                        onClick={onClick}
-                    >
-                        { eventType }
-                    </button>;
-                })
+                Array.from(events.keys()).map((eventType) => (
+                    <StateEventButton key={eventType} label={eventType} onClick={() => setEventType(eventType)} />
+                ))
             }
         </FilteredList>
     </BaseTool>;