OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix themeing bug with Firefox where "disabled" ignored 

A bug in firefox means "disabled" isn't honoured when set in the
HTML. Doing `a.disabled = false` does work however, and Chrome
also appears to honour this.
pull/6301/head
Luke Barnard 2018-03-12 16:15:17 +00:00
parent aa54032500
commit 647c7d7629
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/vector/index.js
View File

@ -263,9 +263,9 @@ async function loadApp() {
} catch (e) { } catch (e) {
configError = e; configError = e;
} }
// XXX: We call this twice, once here and once in MatrixChat as a prop. We call it here to ensure // XXX: We call this twice, once here and once in MatrixChat as a prop. We call it here to ensure
// granular settings are loaded correctly and to avoid duplicating the override logic for the theme. // granular settings are loaded correctly and to avoid duplicating the override logic for the theme.
SdkConfig.put(configJson); SdkConfig.put(configJson);
// don't try to redirect to the native apps if we're // don't try to redirect to the native apps if we're
@ -313,7 +313,11 @@ async function loadApp() {
if (match) { if (match) {
if (match[1] === theme) { if (match[1] === theme) {
// remove the disabled flag off the stylesheet // remove the disabled flag off the stylesheet
a.removeAttribute("disabled");
// Firefox requires setting the attribute to false, so do
// that instead of removing it. Related:
// https://bugzilla.mozilla.org/show_bug.cgi?id=1281135
a.disabled = false;
// in case the Tinter.tint() in MatrixChat fires before the // in case the Tinter.tint() in MatrixChat fires before the
// CSS has actually loaded (which in practice happens)... // CSS has actually loaded (which in practice happens)...
@ -321,9 +325,14 @@ async function loadApp() {
// FIXME: we should probably block loading the app or even // FIXME: we should probably block loading the app or even
// showing a spinner until the theme is loaded, to avoid // showing a spinner until the theme is loaded, to avoid
// flashes of unstyled content. // flashes of unstyled content.
a.onload = () => { a.onload = () => {
Tinter.setTheme(theme); Tinter.setTheme(theme);
}; };
} else {
// Firefox requires this to not be done via `setAttribute`
// or via HTML.
// https://bugzilla.mozilla.org/show_bug.cgi?id=1281135
a.disabled = true;
} }
} }
} }