From 694ee5a2c87931833a1818082f064d1e1bd0eea7 Mon Sep 17 00:00:00 2001 From: Bruno Windels Date: Mon, 10 Sep 2018 18:09:11 +0200 Subject: [PATCH 1/2] fix logging room id when LL members fail --- src/components/structures/RoomView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/structures/RoomView.js b/src/components/structures/RoomView.js index 54f730de5d..c6bd285b49 100644 --- a/src/components/structures/RoomView.js +++ b/src/components/structures/RoomView.js @@ -318,7 +318,7 @@ module.exports = React.createClass({ // lazy load members if enabled if (SettingsStore.isFeatureEnabled('feature_lazyloading')) { room.loadMembersIfNeeded().catch((err) => { - const errorMessage = `Fetching room members for ${this.roomId} failed.` + + const errorMessage = `Fetching room members for ${roomId} failed.` + " Room members will appear incomplete."; console.error(errorMessage); console.error(err); From deaad4bcb17d30a89df394b71d7419bb4d5e3f94 Mon Sep 17 00:00:00 2001 From: Bruno Windels Date: Mon, 10 Sep 2018 18:11:08 +0200 Subject: [PATCH 2/2] even better as the method called is on room --- src/components/structures/RoomView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/structures/RoomView.js b/src/components/structures/RoomView.js index c6bd285b49..88c1d153eb 100644 --- a/src/components/structures/RoomView.js +++ b/src/components/structures/RoomView.js @@ -318,7 +318,7 @@ module.exports = React.createClass({ // lazy load members if enabled if (SettingsStore.isFeatureEnabled('feature_lazyloading')) { room.loadMembersIfNeeded().catch((err) => { - const errorMessage = `Fetching room members for ${roomId} failed.` + + const errorMessage = `Fetching room members for ${room.roomId} failed.` + " Room members will appear incomplete."; console.error(errorMessage); console.error(err);