OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Use `*` for italics as it doesn't break when used mid-word (#12523) 

* Use `*` for italics as it doesn't break when used mid-word

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
pull/28217/head
Michael Telatynski 2024-05-15 10:01:45 +01:00 committed by GitHub
parent 77a724526e
commit 667a7548a7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/editor/operations.ts
View File

@ -48,7 +48,7 @@ export function formatRange(range: Range, action: Formatting): void {
toggleInlineFormat(range, "**"); toggleInlineFormat(range, "**");
break; break;
case Formatting.Italics: case Formatting.Italics:
toggleInlineFormat(range, "_"); toggleInlineFormat(range, "*");
break; break;
case Formatting.Strikethrough: case Formatting.Strikethrough:
toggleInlineFormat(range, "<del>", "</del>"); toggleInlineFormat(range, "<del>", "</del>");

8
test/editor/operations-test.ts
View File

@ -101,7 +101,7 @@ describe("editor/operations: formatting operations", () => {
expect(range.parts[0].text).toBe("world"); expect(range.parts[0].text).toBe("world");
expect(model.serializeParts()).toEqual([{ text: "hello world!", type: "plain" }]); expect(model.serializeParts()).toEqual([{ text: "hello world!", type: "plain" }]);
formatRange(range, Formatting.Italics); formatRange(range, Formatting.Italics);
expect(model.serializeParts()).toEqual([{ text: "hello _world_!", type: "plain" }]); expect(model.serializeParts()).toEqual([{ text: "hello *world*!", type: "plain" }]);
}); });
describe("escape backticks", () => { describe("escape backticks", () => {
@ -204,9 +204,9 @@ describe("editor/operations: formatting operations", () => {
]); ]);
formatRange(range, Formatting.Italics); formatRange(range, Formatting.Italics);
expect(model.serializeParts()).toEqual([ expect(model.serializeParts()).toEqual([
{ text: "hello _there ", type: "plain" }, { text: "hello *there ", type: "plain" },
{ text: "@room", type: "at-room-pill" }, { text: "@room", type: "at-room-pill" },
{ text: ", how are you_ doing?", type: "plain" }, { text: ", how are you* doing?", type: "plain" },
]); ]);
}); });
@ -377,7 +377,7 @@ describe("editor/operations: formatting operations", () => {
// We expect formatting to still happen in the first line as the caret should not jump down // We expect formatting to still happen in the first line as the caret should not jump down
expect(model.serializeParts()).toEqual([ expect(model.serializeParts()).toEqual([
{ text: "hello _hello!_", type: "plain" }, { text: "hello *hello!*", type: "plain" },
SERIALIZED_NEWLINE, SERIALIZED_NEWLINE,
{ text: "world", type: "plain" }, { text: "world", type: "plain" },
]); ]);