From 6a5682897446e362ce9d86867cb2f2010d5d965f Mon Sep 17 00:00:00 2001
From: David Baker <dave@matrix.org>
Date: Wed, 22 Mar 2017 11:25:33 +0000
Subject: [PATCH] Just return the promise if it's a bg request

This makes the code a bit neater.
---
 src/components/structures/InteractiveAuth.js | 33 ++++++++++----------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git a/src/components/structures/InteractiveAuth.js b/src/components/structures/InteractiveAuth.js
index fe7552d20f..7c8a5b8065 100644
--- a/src/components/structures/InteractiveAuth.js
+++ b/src/components/structures/InteractiveAuth.js
@@ -141,26 +141,25 @@ export default React.createClass({
     },
 
     _requestCallback: function(auth, background) {
-        // only set the busy flag if this is a non-background request,
-        // otherwise, the user initiated a request, so make the busy
-        // spinner appear and clear and existing error messages.
-        if (!background) {
-            this.setState({
-                busy: true,
-                errorText: null,
-                stageErrorText: null,
-            });
-        }
-        return this.props.makeRequest(auth).finally(() => {
+        const makeRequestPromise = this.props.makeRequest(auth);
+
+        // if it's a background request, just do it: we don't want
+        // it to affect the state of our UI.
+        if (background) return makeRequestPromise;
+
+        // otherwise, manage the state of the spinner and error messages
+        this.setState({
+            busy: true,
+            errorText: null,
+            stageErrorText: null,
+        });
+        return makeRequestPromise.finally(() => {
             if (this._unmounted) {
                 return;
             }
-            // only unset the busy flag if this is a non-background request
-            if (!background) {
-                this.setState({
-                    busy: false,
-                });
-            }
+            this.setState({
+                busy: false,
+            });
         });
     },