OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Flatten arrays of components before adding to messagepanel li 

Avoid updating the whole DOM when we paginating by making sure the keys are
right
pull/21833/head
Richard van der Hoff 2016-03-04 13:49:15 +00:00
parent 05a3dab528
commit 6e86d7553f
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/components/structures/MessagePanel.js
View File

@ -198,7 +198,10 @@ module.exports = React.createClass({
var last = (i == lastShownEventIndex); var last = (i == lastShownEventIndex);
if (wantTile) { if (wantTile) {
ret.push(this._getTilesForEvent(prevEvent, mxEv, last)); // make sure we unpack the array returned by _getTilesForEvent,
// otherwise react will auto-generate keys and we will end up
// replacing all of the DOM elements every time we paginate.
ret.push(...this._getTilesForEvent(prevEvent, mxEv, last));
prevEvent = mxEv; prevEvent = mxEv;
} else if (!mxEv.status) { } else if (!mxEv.status) {
// if we aren't showing the event, put in a dummy scroll token anyway, so // if we aren't showing the event, put in a dummy scroll token anyway, so