Merge pull request #5294 from matrix-org/t3chguy/fix/w2

Fix StopGapWidget infinitely recursing
pull/21833/head
Michael Telatynski 2020-10-07 11:08:44 +01:00 committed by GitHub
commit 709d33c21c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 2 deletions

View File

@ -62,7 +62,8 @@ export default class AccessibleTooltipButton extends React.PureComponent<IToolti
}; };
render() { render() {
const {title, tooltip, children, tooltipClassName, ...props} = this.props; // eslint-disable-next-line @typescript-eslint/no-unused-vars
const {title, tooltip, children, tooltipClassName, forceHide, ...props} = this.props;
const tip = this.state.hover ? <Tooltip const tip = this.state.hover ? <Tooltip
className="mx_AccessibleTooltipButton_container" className="mx_AccessibleTooltipButton_container"

View File

@ -437,6 +437,7 @@ export default class MessageComposer extends React.Component {
const canEndConf = WidgetUtils.canUserModifyWidgets(this.props.room.roomId); const canEndConf = WidgetUtils.canUserModifyWidgets(this.props.room.roomId);
controls.push( controls.push(
<HangupButton <HangupButton
key="controls_hangup"
roomId={this.props.room.roomId} roomId={this.props.room.roomId}
isConference={true} isConference={true}
canEndConference={canEndConf} canEndConference={canEndConf}

View File

@ -66,7 +66,7 @@ class ElementWidget extends Widget {
if (WidgetType.JITSI.matches(this.type)) { if (WidgetType.JITSI.matches(this.type)) {
return WidgetUtils.getLocalJitsiWrapperUrl({ return WidgetUtils.getLocalJitsiWrapperUrl({
forLocalRender: true, forLocalRender: true,
auth: this.rawData?.auth, auth: super.rawData?.auth, // this.rawData can call templateUrl, do this to prevent looping
}); });
} }
return super.templateUrl; return super.templateUrl;