OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

allow fractional values for scrollTop above and below expected value

pull/21833/head
Bruno Windels 2019-04-02 17:53:53 +02:00
parent d92336fc16
commit 726e91101a
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/components/structures/ScrollPanel.js
View File

@ -222,10 +222,12 @@ module.exports = React.createClass({
// whether it will stay that way when the children update. // whether it will stay that way when the children update.
isAtBottom: function() { isAtBottom: function() {
const sn = this._getScrollNode(); const sn = this._getScrollNode();
// fractional values for scrollTop happen on certain browsers/platforms // fractional values (both too big and too small)
// for scrollTop happen on certain browsers/platforms
// when scrolled all the way down. E.g. Chrome 72 on debian. // when scrolled all the way down. E.g. Chrome 72 on debian.
// so ceil everything upwards to make sure it aligns. // so check difference <= 1;
return Math.ceil(sn.scrollTop) === Math.ceil(sn.scrollHeight - sn.clientHeight); return Math.abs(sn.scrollHeight - (sn.scrollTop + sn.clientHeight)) <= 1;
}, },
// returns the vertical height in the given direction that can be removed from // returns the vertical height in the given direction that can be removed from