OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

TAC: Fix CSS & component typos (#12333) 

* Fix CSS & component typo

* Update snapshots
pull/28217/head
Florian Duros 2024-03-11 16:48:11 +01:00 committed by GitHub
parent 431ae32304
commit 753fc2d33a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
res/css/structures/_ThreadsActivityCentre.pcss
View File

@ -62,12 +62,12 @@
}
}
.mx_ThreadsActivity_rows {
.mx_ThreadsActivityCentre_rows {
overflow-y: scroll;
/* Let some space at the top and the bottom of the pop-up */
max-height: calc(100vh - 200px);
.mx_ThreadsActivityRow {
.mx_ThreadsActivityCentreRow {
height: 48px;
/* Make the label of the MenuItem stay on one line and truncate with ellipsis if needed */

8
src/components/views/spaces/threads-activity-centre/ThreadsActivityCentre.tsx
View File

@ -84,9 +84,9 @@ export function ThreadsActivityCentre({ displayButtonLabel }: ThreadsActivityCen
}
>
{/* Make the content of the pop-up scrollable */}
<div className="mx_ThreadsActivity_rows">
<div className="mx_ThreadsActivityCentre_rows">
{roomsAndNotifications.rooms.map(({ room, notificationLevel }) => (
<ThreadsActivityRow
<ThreadsActivityCentreRow
key={room.roomId}
room={room}
notificationLevel={notificationLevel}
@ -122,10 +122,10 @@ interface ThreadsActivityRow {
/**
* Display a room with unread threads.
*/
function ThreadsActivityRow({ room, onClick, notificationLevel }: ThreadsActivityRow): JSX.Element {
function ThreadsActivityCentreRow({ room, onClick, notificationLevel }: ThreadsActivityRow): JSX.Element {
return (
<MenuItem
className="mx_ThreadsActivityRow"
className="mx_ThreadsActivityCentreRow"
onSelect={(event: Event) => {
onClick();

8
test/components/views/spaces/__snapshots__/ThreadsActivityCentre-test.tsx.snap
View File

@ -23,10 +23,10 @@ exports[`ThreadsActivityCentre renders notifications matching the snapshot 1`] =
Threads activity
</h3>
<div
class="mx_ThreadsActivity_rows"
class="mx_ThreadsActivityCentre_rows"
>
<button
class="mx_ThreadsActivityRow _item_1gwvj_17 _interactive_1gwvj_36"
class="mx_ThreadsActivityCentreRow _item_1gwvj_17 _interactive_1gwvj_36"
data-kind="primary"
data-orientation="vertical"
data-radix-collection-item=""
@ -74,7 +74,7 @@ exports[`ThreadsActivityCentre renders notifications matching the snapshot 1`] =
</div>
</button>
<button
class="mx_ThreadsActivityRow _item_1gwvj_17 _interactive_1gwvj_36"
class="mx_ThreadsActivityCentreRow _item_1gwvj_17 _interactive_1gwvj_36"
data-kind="primary"
data-orientation="vertical"
data-radix-collection-item=""
@ -148,7 +148,7 @@ exports[`ThreadsActivityCentre should match snapshot when empty 1`] = `
Threads activity
</h3>
<div
class="mx_ThreadsActivity_rows"
class="mx_ThreadsActivityCentre_rows"
>
<div
class="mx_ThreadsActivityCentre_emptyCaption"