From 7601ce93d90b37917d7bc824495db427e192022a Mon Sep 17 00:00:00 2001
From: "J. Ryan Stinnett" <jryans@gmail.com>
Date: Thu, 5 Dec 2019 15:33:10 +0000
Subject: [PATCH] Add in-memory cache of secret storage keys

---
 src/CrossSigningManager.js | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/CrossSigningManager.js b/src/CrossSigningManager.js
index 56feadd5d7..c8738ece88 100644
--- a/src/CrossSigningManager.js
+++ b/src/CrossSigningManager.js
@@ -32,6 +32,13 @@ const crossSigningKeys = {};
 export const getCrossSigningKey = k => crossSigningKeys[k];
 export const saveCrossSigningKeys = newKeys => Object.assign(crossSigningKeys, newKeys);
 
+// This stores the secret storage private keys in memory for the JS SDK. This is
+// only meant to act as a cache to avoid prompting the user multiple times
+// during the same session. It is considered unsafe to persist this to normal
+// web storage. For platforms with a secure enclave, we will store this key
+// there.
+const secretStorageKeys = {};
+
 // XXX: This flow should maybe be reworked to allow retries in case of typos,
 // etc.
 export const getSecretStorageKey = async keyInfos => {
@@ -40,6 +47,10 @@ export const getSecretStorageKey = async keyInfos => {
         throw new Error("Multiple storage key requests not implemented");
     }
     const [name, info] = keyInfoEntries[0];
+    // Check the in-memory cache
+    if (secretStorageKeys[name]) {
+        return [name, secretStorageKeys[name]];
+    }
     const AccessSecretStorageDialog =
         sdk.getComponent("dialogs.secretstorage.AccessSecretStorageDialog");
     const { finished } = Modal.createTrackedDialog("Access Secret Storage dialog", "",
@@ -58,5 +69,7 @@ export const getSecretStorageKey = async keyInfos => {
     } else {
         key = decodeRecoveryKey(input);
     }
+    // Save to cache to avoid future prompts in the current session
+    secretStorageKeys[name] = key;
     return [name, key];
 };