From 762e6780d70b8a740033921e063061c4b485ad53 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Wed, 26 Jul 2017 11:51:41 +0100 Subject: [PATCH] fix this hiding unbans as found by Luke's review --- src/shouldHideEvent.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/shouldHideEvent.js b/src/shouldHideEvent.js index c97ee2cd3c..6e0926e684 100644 --- a/src/shouldHideEvent.js +++ b/src/shouldHideEvent.js @@ -36,8 +36,11 @@ function _isLeaveOrJoin(ev) { // dupe join event, fall through to hide rules } + // this only applies to joins/leaves not invites/kicks/bans - return membership === 'join' || (membership === 'leave' && ev.getStateKey() === ev.getSender()); + const isJoin = membership === 'join' && prevMembership !== 'ban'; + const isLeave = membership === 'leave' && ev.getStateKey() === ev.getSender(); + return isJoin || isLeave; } export default function(ev, syncedSettings) {