Fix click background to deselect

pull/21833/head
Luke Barnard 2018-02-16 18:08:29 +00:00
parent 113fc696d8
commit 7a0c82a327
1 changed files with 5 additions and 8 deletions

View File

@ -84,8 +84,6 @@ const TagPanel = React.createClass({
}, },
onClick(e) { onClick(e) {
// Ignore clicks on children
if (e.target !== e.currentTarget) return;
dis.dispatch({action: 'deselect_tags'}); dis.dispatch({action: 'deselect_tags'});
}, },
@ -116,7 +114,11 @@ const TagPanel = React.createClass({
<img src="img/logos/riot-logo.svg" /> <img src="img/logos/riot-logo.svg" />
</AccessibleButton> </AccessibleButton>
<div className="mx_TagPanel_divider" /> <div className="mx_TagPanel_divider" />
<GeminiScrollbar autoShow={true} className="mx_TagPanel_scroller"> <GeminiScrollbar
className="mx_TagPanel_scroller"
autoShow={true}
onClick={this.onClick}
>
<Droppable <Droppable
droppableId="tag-panel-droppable" droppableId="tag-panel-droppable"
type="draggable-TagTile" type="draggable-TagTile"
@ -125,11 +127,6 @@ const TagPanel = React.createClass({
<div <div
className="mx_TagPanel_tagTileContainer" className="mx_TagPanel_tagTileContainer"
ref={provided.innerRef} ref={provided.innerRef}
// react-beautiful-dnd has a bug that emits a click to the parent
// of draggables upon dropping
// https://github.com/atlassian/react-beautiful-dnd/issues/273
// so we use onMouseDown here as a workaround.
onMouseDown={this.onClick}
> >
{ tags } { tags }
{ provided.placeholder } { provided.placeholder }