From 7a5e172b88c959f94051db1f6d7424cf0ef8108f Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Fri, 24 Jan 2020 16:16:46 +0000 Subject: [PATCH] Apply a huge part of the decorations and copy --- res/css/_components.scss | 2 + .../views/right_panel/_EncryptionInfo.scss | 24 + res/css/views/right_panel/_UserInfo.scss | 6 +- .../views/right_panel/_VerificationPanel.scss | 21 + src/components/structures/RightPanel.js | 25 +- .../views/messages/MKeyVerificationRequest.js | 3 +- .../views/right_panel/EncryptionInfo.js | 68 +- .../views/right_panel/EncryptionPanel.js | 72 +- src/components/views/right_panel/UserInfo.js | 619 ++++++++++-------- .../views/right_panel/VerificationPanel.js | 85 ++- .../views/toasts/VerificationRequestToast.js | 6 +- .../views/verification/VerificationShowSas.js | 55 +- src/i18n/strings/en_EN.json | 18 +- 13 files changed, 586 insertions(+), 418 deletions(-) create mode 100644 res/css/views/right_panel/_EncryptionInfo.scss create mode 100644 res/css/views/right_panel/_VerificationPanel.scss diff --git a/res/css/_components.scss b/res/css/_components.scss index 60f749de9c..e19050dc7e 100644 --- a/res/css/_components.scss +++ b/res/css/_components.scss @@ -140,7 +140,9 @@ @import "./views/messages/_TextualEvent.scss"; @import "./views/messages/_UnknownBody.scss"; @import "./views/messages/_ViewSourceEvent.scss"; +@import "./views/right_panel/_EncryptionInfo.scss"; @import "./views/right_panel/_UserInfo.scss"; +@import "./views/right_panel/_VerificationPanel.scss"; @import "./views/room_settings/_AliasSettings.scss"; @import "./views/room_settings/_ColorSettings.scss"; @import "./views/rooms/_AppsDrawer.scss"; diff --git a/res/css/views/right_panel/_EncryptionInfo.scss b/res/css/views/right_panel/_EncryptionInfo.scss new file mode 100644 index 0000000000..386eef8e7f --- /dev/null +++ b/res/css/views/right_panel/_EncryptionInfo.scss @@ -0,0 +1,24 @@ +/* +Copyright 2020 The Matrix.org Foundation C.I.C. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +.mx_UserInfo { + .mx_EncryptionInfo_spinner { + .mx_Spinner { + margin-top: 25px; + margin-bottom: 15px; + } + } +} diff --git a/res/css/views/right_panel/_UserInfo.scss b/res/css/views/right_panel/_UserInfo.scss index 57ffd4982e..8aad5240aa 100644 --- a/res/css/views/right_panel/_UserInfo.scss +++ b/res/css/views/right_panel/_UserInfo.scss @@ -81,6 +81,7 @@ limitations under the License. .mx_UserInfo_avatar > div { max-width: 30vh; margin: 0 auto; + transition: 1s; } .mx_UserInfo_avatar > div > div { @@ -260,11 +261,6 @@ limitations under the License. .mx_UserInfo_verify { display: block; - background-color: $accent-color; - color: $accent-fg-color; - border-radius: 4px; - padding: 7px 1.5em; - text-align: center; margin: 16px 0; } } diff --git a/res/css/views/right_panel/_VerificationPanel.scss b/res/css/views/right_panel/_VerificationPanel.scss new file mode 100644 index 0000000000..84a82c9a5c --- /dev/null +++ b/res/css/views/right_panel/_VerificationPanel.scss @@ -0,0 +1,21 @@ +/* +Copyright 2020 The Matrix.org Foundation C.I.C. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +.mx_UserInfo { + .mx_VerificationPanel_verified_section .mx_E2EIcon { + margin: 0 auto; + } +} diff --git a/src/components/structures/RightPanel.js b/src/components/structures/RightPanel.js index c01a3709e7..2188bda4f2 100644 --- a/src/components/structures/RightPanel.js +++ b/src/components/structures/RightPanel.js @@ -169,7 +169,6 @@ export default class RightPanel extends React.Component { const MemberList = sdk.getComponent('rooms.MemberList'); const MemberInfo = sdk.getComponent('rooms.MemberInfo'); const UserInfo = sdk.getComponent('right_panel.UserInfo'); - const EncryptionPanel = sdk.getComponent('right_panel.EncryptionPanel'); const ThirdPartyMemberInfo = sdk.getComponent('rooms.ThirdPartyMemberInfo'); const NotificationPanel = sdk.getComponent('structures.NotificationPanel'); const FilePanel = sdk.getComponent('structures.FilePanel'); @@ -187,19 +186,22 @@ export default class RightPanel extends React.Component { panel = ; } else if (this.state.phase === RIGHT_PANEL_PHASES.GroupRoomList) { panel = ; - } else if (this.state.phase === RIGHT_PANEL_PHASES.RoomMemberInfo) { + } else if (this.state.phase === RIGHT_PANEL_PHASES.RoomMemberInfo || + this.state.phase === RIGHT_PANEL_PHASES.EncryptionPanel) { if (SettingsStore.isFeatureEnabled("feature_cross_signing")) { const onClose = () => { dis.dispatch({ action: "view_user", - member: null, + member: this.state.phase === RIGHT_PANEL_PHASES.EncryptionPanel ? this.state.member : null, }); }; panel = ; } else { panel = ; @@ -215,7 +217,7 @@ export default class RightPanel extends React.Component { }); }; panel = ; @@ -237,19 +239,6 @@ export default class RightPanel extends React.Component { panel = ; } else if (this.state.phase === RIGHT_PANEL_PHASES.FilePanel) { panel = ; - } else if (this.state.phase === RIGHT_PANEL_PHASES.EncryptionPanel) { - const onClose = () => { - dis.dispatch({ - action: "view_user", - member: this.state.member, - }); - }; - panel = ( - - ); } const classes = classNames("mx_RightPanel", "mx_fadable", { diff --git a/src/components/views/messages/MKeyVerificationRequest.js b/src/components/views/messages/MKeyVerificationRequest.js index ae793556d8..474ff7becb 100644 --- a/src/components/views/messages/MKeyVerificationRequest.js +++ b/src/components/views/messages/MKeyVerificationRequest.js @@ -45,10 +45,11 @@ export default class MKeyVerificationRequest extends React.Component { _openRequest = () => { const {verificationRequest} = this.props.mxEvent; + const member = MatrixClientPeg.get().getUser(verificationRequest.otherUserId); dis.dispatch({ action: "set_right_panel_phase", phase: RIGHT_PANEL_PHASES.EncryptionPanel, - refireParams: {verificationRequest}, + refireParams: {verificationRequest, member}, }); }; diff --git a/src/components/views/right_panel/EncryptionInfo.js b/src/components/views/right_panel/EncryptionInfo.js index 2d265967ae..8868c30053 100644 --- a/src/components/views/right_panel/EncryptionInfo.js +++ b/src/components/views/right_panel/EncryptionInfo.js @@ -1,5 +1,5 @@ /* -Copyright 2019 The Matrix.org Foundation C.I.C. +Copyright 2019, 2020 The Matrix.org Foundation C.I.C. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -14,24 +14,58 @@ See the License for the specific language governing permissions and limitations under the License. */ -import React from 'react'; -import * as sdk from '../../../index'; +import React from "react"; +import PropTypes from "prop-types"; + +import * as sdk from "../../../index"; import {_t} from "../../../languageHandler"; -export default class EncryptionInfo extends React.PureComponent { - render() { +export const PendingActionSpinner = ({text}) => { + const Spinner = sdk.getComponent('elements.Spinner'); + return
+ + { text } +
; +}; + +const EncryptionInfo = ({pending, member, onStartVerification}) => { + let content; + if (pending) { + const text = _t("Waiting for %(displayName)s to accept…", { + displayName: member.displayName || member.name || member.userId, + }); + content = ; + } else { const AccessibleButton = sdk.getComponent('elements.AccessibleButton'); - return ( -
-

{_t("Verify User")}

-
-

{_t("For extra security, verify this user by checking a one-time code on both of your devices.")}

-

{_t("For maximum security, do this in person.")}

- - {_t("Start Verification")} - -
-
+ content = ( + + {_t("Start Verification")} + ); } -} + + return +
+

{_t("Encryption")}

+
+

{_t("Messages in this room are end-to-end encrypted.")}

+

{_t("Your messages are secured and only you and the recipient have the unique keys to unlock them.")}

+
+
+
+

{_t("Verify User")}

+
+

{_t("For extra security, verify this user by checking a one-time code on both of your devices.")}

+

{_t("For maximum security, do this in person.")}

+ { content } +
+
+
; +}; +EncryptionInfo.propTypes = { + member: PropTypes.object.isRequired, + onStartVerification: PropTypes.func.isRequired, + request: PropTypes.object, +}; + +export default EncryptionInfo; diff --git a/src/components/views/right_panel/EncryptionPanel.js b/src/components/views/right_panel/EncryptionPanel.js index a1008543e4..dfb145f61d 100644 --- a/src/components/views/right_panel/EncryptionPanel.js +++ b/src/components/views/right_panel/EncryptionPanel.js @@ -14,52 +14,42 @@ See the License for the specific language governing permissions and limitations under the License. */ -import React from 'react'; +import React, {useCallback, useEffect, useState} from 'react'; + import EncryptionInfo from "./EncryptionInfo"; import VerificationPanel from "./VerificationPanel"; import {MatrixClientPeg} from "../../../MatrixClientPeg"; import {ensureDMExists} from "../../../createRoom"; -import {UserInfoPane} from "./UserInfo"; -import {_t} from "../../../languageHandler"; +import {useEventEmitter} from "../../../hooks/useEventEmitter"; -export default class EncryptionPanel extends React.PureComponent { - constructor(props) { - super(props); - this.state = {}; +const EncryptionPanel = ({verificationRequest, member}) => { + const [request, setRequest] = useState(verificationRequest); + useEffect(() => { + setRequest(verificationRequest); + }, [verificationRequest]); + + const [pending, setPending] = useState(false); + const changeHandler = useCallback(() => { + setPending(request && request.requested); + }, [request]); + useEventEmitter(request, "change", changeHandler); + useEffect(changeHandler, [changeHandler]); + + const onStartVerification = useCallback(async () => { + const cli = MatrixClientPeg.get(); + const roomId = await ensureDMExists(cli, member.userId); + const verificationRequest = await cli.requestVerificationDM(member.userId, roomId); + setRequest(verificationRequest); + }, [member.userId]); + + if (!request || pending) { + return ; + } else { + return ; } +}; +EncryptionPanel.propTypes = { - render() { - let content; - const request = this.props.verificationRequest || this.state.verificationRequest; - const {member} = this.props; - if (request) { - content = ; - } else if (member) { - content = ; - } else { - content =

Not a member nor request, not sure what to render

; - } +}; - return ( - -
-

{_t("Encryption")}

-
-

{_t("Messages in this room are end-to-end encrypted.")}

-

{_t("Your messages are secured and only you and the recipient have the unique keys to unlock them.")}

-
-
- - { content } -
- ); - } - - _onStartVerification = async () => { - const client = MatrixClientPeg.get(); - const {member} = this.props; - const roomId = await ensureDMExists(client, member.userId); - const verificationRequest = await client.requestVerificationDM(member.userId, roomId); - this.setState({verificationRequest}); - }; -} +export default EncryptionPanel; diff --git a/src/components/views/right_panel/UserInfo.js b/src/components/views/right_panel/UserInfo.js index a31e9a6ce0..41dbe49cc8 100644 --- a/src/components/views/right_panel/UserInfo.js +++ b/src/components/views/right_panel/UserInfo.js @@ -41,6 +41,7 @@ import {useEventEmitter} from "../../../hooks/useEventEmitter"; import {textualPowerLevel} from '../../../Roles'; import MatrixClientContext from "../../../contexts/MatrixClientContext"; import {RIGHT_PANEL_PHASES} from "../../../stores/RightPanelStorePhases"; +import EncryptionPanel from "./EncryptionPanel"; const _disambiguateDevices = (devices) => { const names = Object.create(null); @@ -1047,7 +1048,256 @@ const PowerLevelEditor = ({user, room, roomPermissions, onFinished}) => { ); }; -export const UserInfoPane = ({children, className, onClose, e2eStatus, member}) => { +export const useDevices = (userId) => { + const cli = useContext(MatrixClientContext); + + // undefined means yet to be loaded, null means failed to load, otherwise list of devices + const [devices, setDevices] = useState(undefined); + // Download device lists + useEffect(() => { + setDevices(undefined); + + let cancelled = false; + + async function _downloadDeviceList() { + try { + await cli.downloadKeys([userId], true); + const devices = await cli.getStoredDevicesForUser(userId); + + if (cancelled) { + // we got cancelled - presumably a different user now + return; + } + + _disambiguateDevices(devices); + setDevices(devices); + } catch (err) { + setDevices(null); + } + } + _downloadDeviceList(); + + // Handle being unmounted + return () => { + cancelled = true; + }; + }, [cli, userId]); + + // Listen to changes + useEffect(() => { + let cancel = false; + const onDeviceVerificationChanged = (_userId, device) => { + if (_userId === userId) { + // no need to re-download the whole thing; just update our copy of the list. + + // Promise.resolve to handle transition from static result to promise; can be removed in future + Promise.resolve(cli.getStoredDevicesForUser(userId)).then((devices) => { + if (cancel) return; + console.log("setDevices 2", devices); + setDevices(devices); + }); + } + }; + cli.on("deviceVerificationChanged", onDeviceVerificationChanged); + // Handle being unmounted + return () => { + cancel = true; + cli.removeListener("deviceVerificationChanged", onDeviceVerificationChanged); + }; + }, [cli, userId]); + + return devices; +}; + +const BasicUserInfo = ({room, member, groupId, devices, isRoomEncrypted}) => { + const cli = useContext(MatrixClientContext); + + const powerLevels = useRoomPowerLevels(cli, room); + // Load whether or not we are a Synapse Admin + const isSynapseAdmin = useIsSynapseAdmin(cli); + + // Check whether the user is ignored + const [isIgnored, setIsIgnored] = useState(cli.isUserIgnored(member.userId)); + // Recheck if the user or client changes + useEffect(() => { + setIsIgnored(cli.isUserIgnored(member.userId)); + }, [cli, member.userId]); + // Recheck also if we receive new accountData m.ignored_user_list + const accountDataHandler = useCallback((ev) => { + if (ev.getType() === "m.ignored_user_list") { + setIsIgnored(cli.isUserIgnored(member.userId)); + } + }, [cli, member.userId]); + useEventEmitter(cli, "accountData", accountDataHandler); + + // Count of how many operations are currently in progress, if > 0 then show a Spinner + const [pendingUpdateCount, setPendingUpdateCount] = useState(0); + const startUpdating = useCallback(() => { + setPendingUpdateCount(pendingUpdateCount + 1); + }, [pendingUpdateCount]); + const stopUpdating = useCallback(() => { + setPendingUpdateCount(pendingUpdateCount - 1); + }, [pendingUpdateCount]); + + const roomPermissions = useRoomPermissions(cli, room, member); + + const onSynapseDeactivate = useCallback(async () => { + const QuestionDialog = sdk.getComponent('views.dialogs.QuestionDialog'); + const {finished} = Modal.createTrackedDialog('Synapse User Deactivation', '', QuestionDialog, { + title: _t("Deactivate user?"), + description: +
{ _t( + "Deactivating this user will log them out and prevent them from logging back in. Additionally, " + + "they will leave all the rooms they are in. This action cannot be reversed. Are you sure you " + + "want to deactivate this user?", + ) }
, + button: _t("Deactivate user"), + danger: true, + }); + + const [accepted] = await finished; + if (!accepted) return; + try { + await cli.deactivateSynapseUser(member.userId); + } catch (err) { + console.error("Failed to deactivate user"); + console.error(err); + + const ErrorDialog = sdk.getComponent('dialogs.ErrorDialog'); + Modal.createTrackedDialog('Failed to deactivate Synapse user', '', ErrorDialog, { + title: _t('Failed to deactivate user'), + description: ((err && err.message) ? err.message : _t("Operation failed")), + }); + } + }, [cli, member.userId]); + + let synapseDeactivateButton; + let spinner; + + // We don't need a perfect check here, just something to pass as "probably not our homeserver". If + // someone does figure out how to bypass this check the worst that happens is an error. + // FIXME this should be using cli instead of MatrixClientPeg.matrixClient + if (isSynapseAdmin && member.userId.endsWith(`:${MatrixClientPeg.getHomeserverName()}`)) { + synapseDeactivateButton = ( + + {_t("Deactivate user")} + + ); + } + + let adminToolsContainer; + if (room && member.roomId) { + adminToolsContainer = ( + + { synapseDeactivateButton } + + ); + } else if (groupId) { + adminToolsContainer = ( + + { synapseDeactivateButton } + + ); + } else if (synapseDeactivateButton) { + adminToolsContainer = ( + + { synapseDeactivateButton } + + ); + } + + if (pendingUpdateCount > 0) { + const Loader = sdk.getComponent("elements.Spinner"); + spinner = ; + } + + const memberDetails = ( + + ); + + // only display the devices list if our client supports E2E + const _enableDevices = cli.isCryptoEnabled(); + + let text; + if (!isRoomEncrypted) { + if (!_enableDevices) { + text = _t("This client does not support end-to-end encryption."); + } else if (room) { + text = _t("Messages in this room are not end-to-end encrypted."); + } else { + // TODO what to render for GroupMember + } + } else { + text = _t("Messages in this room are end-to-end encrypted."); + } + + const userTrust = cli.checkUserTrust(member.userId); + const userVerified = SettingsStore.isFeatureEnabled("feature_cross_signing") ? + userTrust.isCrossSigningVerified() : + userTrust.isVerified(); + const isMe = member.userId === cli.getUserId(); + let verifyButton; + if (isRoomEncrypted && !userVerified && !isMe) { + verifyButton = ( + verifyUser(member)}> + {_t("Verify")} + + ); + } + + let devicesSection; + if (isRoomEncrypted) { + devicesSection = ; + } + + const securitySection = ( +
+

{ _t("Security") }

+

{ text }

+ { verifyButton } + { devicesSection } +
+ ); + + return + { memberDetails && +
+
+ { memberDetails } +
+
} + + { securitySection } + + + { adminToolsContainer } + + { spinner } +
; +}; + +const UserInfoHeader = ({onClose, member, e2eStatus}) => { const cli = useContext(MatrixClientContext); let closeButton; @@ -1057,6 +1307,38 @@ export const UserInfoPane = ({children, className, onClose, e2eStatus, member}) ; } + const onMemberAvatarClick = useCallback(() => { + const avatarUrl = member.getMxcAvatarUrl ? member.getMxcAvatarUrl() : member.avatarUrl; + if (!avatarUrl) return; + + const httpUrl = cli.mxcUrlToHttp(avatarUrl); + const ImageView = sdk.getComponent("elements.ImageView"); + const params = { + src: httpUrl, + name: member.name, + }; + + Modal.createDialog(ImageView, params, "mx_Dialog_lightbox"); + }, [cli, member]); + + const MemberAvatar = sdk.getComponent('avatars.MemberAvatar'); + const avatarElement = ( +
+
+
+ +
+
+
+ ); + let presenceState; let presenceLastActiveAgo; let presenceCurrentlyActive; @@ -1091,74 +1373,35 @@ export const UserInfoPane = ({children, className, onClose, e2eStatus, member}) statusLabel = { statusMessage }; } - const onMemberAvatarClick = useCallback(() => { - const avatarUrl = member.getMxcAvatarUrl ? member.getMxcAvatarUrl() : member.avatarUrl; - if (!avatarUrl) return; - - const httpUrl = cli.mxcUrlToHttp(avatarUrl); - const ImageView = sdk.getComponent("elements.ImageView"); - const params = { - src: httpUrl, - name: member.name, - }; - - Modal.createDialog(ImageView, params, "mx_Dialog_lightbox"); - }, [cli, member]); - - const MemberAvatar = sdk.getComponent('avatars.MemberAvatar'); - const avatarElement = ( -
-
-
- -
-
-
- ); - let e2eIcon; if (e2eStatus) { e2eIcon = ; } const displayName = member.name || member.displayname; + return + { closeButton } + { avatarElement } - return ( -
- - { closeButton } - { avatarElement } - -
-
-
-

- { e2eIcon } - { displayName } -

-
-
{ member.userId }
-
- {presenceLabel} - {statusLabel} -
-
+
+
+
+

+ { e2eIcon } + { displayName } +

- - { children } - +
{ member.userId }
+
+ {presenceLabel} + {statusLabel} +
+
- ); + ; }; -const UserInfo = ({user, groupId, roomId, onClose}) => { +const UserInfo = ({user, groupId, roomId, onClose, phase=RIGHT_PANEL_PHASES.RoomMemberInfo, ...props}) => { const cli = useContext(MatrixClientContext); // Load room if we are given a room id and memoize it @@ -1166,246 +1409,46 @@ const UserInfo = ({user, groupId, roomId, onClose}) => { // fetch latest room member if we have a room, so we don't show historical information, falling back to user const member = useMemo(() => room ? (room.getMember(user.userId) || user) : user, [room, user]); - // only display the devices list if our client supports E2E - const _enableDevices = cli.isCryptoEnabled(); - - const powerLevels = useRoomPowerLevels(cli, room); - // Load whether or not we are a Synapse Admin - const isSynapseAdmin = useIsSynapseAdmin(cli); - - // Check whether the user is ignored - const [isIgnored, setIsIgnored] = useState(cli.isUserIgnored(user.userId)); - // Recheck if the user or client changes - useEffect(() => { - setIsIgnored(cli.isUserIgnored(user.userId)); - }, [cli, user.userId]); - // Recheck also if we receive new accountData m.ignored_user_list - const accountDataHandler = useCallback((ev) => { - if (ev.getType() === "m.ignored_user_list") { - setIsIgnored(cli.isUserIgnored(user.userId)); - } - }, [cli, user.userId]); - useEventEmitter(cli, "accountData", accountDataHandler); - - // Count of how many operations are currently in progress, if > 0 then show a Spinner - const [pendingUpdateCount, setPendingUpdateCount] = useState(0); - const startUpdating = useCallback(() => { - setPendingUpdateCount(pendingUpdateCount + 1); - }, [pendingUpdateCount]); - const stopUpdating = useCallback(() => { - setPendingUpdateCount(pendingUpdateCount - 1); - }, [pendingUpdateCount]); - - const roomPermissions = useRoomPermissions(cli, room, member); - - const onSynapseDeactivate = useCallback(async () => { - const QuestionDialog = sdk.getComponent('views.dialogs.QuestionDialog'); - const {finished} = Modal.createTrackedDialog('Synapse User Deactivation', '', QuestionDialog, { - title: _t("Deactivate user?"), - description: -
{ _t( - "Deactivating this user will log them out and prevent them from logging back in. Additionally, " + - "they will leave all the rooms they are in. This action cannot be reversed. Are you sure you " + - "want to deactivate this user?", - ) }
, - button: _t("Deactivate user"), - danger: true, - }); - - const [accepted] = await finished; - if (!accepted) return; - try { - await cli.deactivateSynapseUser(user.userId); - } catch (err) { - console.error("Failed to deactivate user"); - console.error(err); - - const ErrorDialog = sdk.getComponent('dialogs.ErrorDialog'); - Modal.createTrackedDialog('Failed to deactivate Synapse user', '', ErrorDialog, { - title: _t('Failed to deactivate user'), - description: ((err && err.message) ? err.message : _t("Operation failed")), - }); - } - }, [cli, user.userId]); - - let synapseDeactivateButton; - let spinner; - - // We don't need a perfect check here, just something to pass as "probably not our homeserver". If - // someone does figure out how to bypass this check the worst that happens is an error. - // FIXME this should be using cli instead of MatrixClientPeg.matrixClient - if (isSynapseAdmin && user.userId.endsWith(`:${MatrixClientPeg.getHomeserverName()}`)) { - synapseDeactivateButton = ( - - {_t("Deactivate user")} - - ); - } - - let adminToolsContainer; - if (room && member.roomId) { - adminToolsContainer = ( - - { synapseDeactivateButton } - - ); - } else if (groupId) { - adminToolsContainer = ( - - { synapseDeactivateButton } - - ); - } else if (synapseDeactivateButton) { - adminToolsContainer = ( - - { synapseDeactivateButton } - - ); - } - - if (pendingUpdateCount > 0) { - const Loader = sdk.getComponent("elements.Spinner"); - spinner = ; - } - - const memberDetails = ( - - ); - const isRoomEncrypted = useIsEncrypted(cli, room); - // undefined means yet to be loaded, null means failed to load, otherwise list of devices - const [devices, setDevices] = useState(undefined); - // Download device lists - useEffect(() => { - setDevices(undefined); - - let cancelled = false; - - async function _downloadDeviceList() { - try { - await cli.downloadKeys([user.userId], true); - const devices = await cli.getStoredDevicesForUser(user.userId); - - if (cancelled) { - // we got cancelled - presumably a different user now - return; - } - - _disambiguateDevices(devices); - setDevices(devices); - } catch (err) { - setDevices(null); - } - } - _downloadDeviceList(); - - // Handle being unmounted - return () => { - cancelled = true; - }; - }, [cli, user.userId]); - - // Listen to changes - useEffect(() => { - let cancel = false; - const onDeviceVerificationChanged = (_userId, device) => { - if (_userId === user.userId) { - // no need to re-download the whole thing; just update our copy of the list. - - // Promise.resolve to handle transition from static result to promise; can be removed in future - Promise.resolve(cli.getStoredDevicesForUser(user.userId)).then((devices) => { - if (cancel) return; - setDevices(devices); - }); - } - }; - cli.on("deviceVerificationChanged", onDeviceVerificationChanged); - // Handle being unmounted - return () => { - cancel = true; - cli.removeListener("deviceVerificationChanged", onDeviceVerificationChanged); - }; - }, [cli, user.userId]); - - let text; - if (!isRoomEncrypted) { - if (!_enableDevices) { - text = _t("This client does not support end-to-end encryption."); - } else if (room) { - text = _t("Messages in this room are not end-to-end encrypted."); - } else { - // TODO what to render for GroupMember - } - } else { - text = _t("Messages in this room are end-to-end encrypted."); - } - - const userTrust = cli.checkUserTrust(user.userId); - const userVerified = SettingsStore.isFeatureEnabled("feature_cross_signing") ? - userTrust.isCrossSigningVerified() : - userTrust.isVerified(); - const isMe = user.userId === cli.getUserId(); - let verifyButton; - if (isRoomEncrypted && !userVerified && !isMe) { - verifyButton = verifyUser(user)}> - {_t("Verify")} - ; - } - - let devicesSection; - if (isRoomEncrypted) { - devicesSection = ; - } - - const securitySection = ( -
-

{ _t("Security") }

-

{ text }

- { verifyButton } - { devicesSection } -
- ); + const devices = useDevices(user.userId); let e2eStatus; if (isRoomEncrypted && devices) { e2eStatus = getE2EStatus(cli, user.userId, devices); } - return - { memberDetails && -
-
- { memberDetails } -
-
} + const classes = ["mx_UserInfo"]; - { securitySection } - + let content; + switch (phase) { + case RIGHT_PANEL_PHASES.RoomMemberInfo: + case RIGHT_PANEL_PHASES.GroupMemberInfo: + content = ( + + ); + break; + case RIGHT_PANEL_PHASES.EncryptionPanel: + classes.push("mx_UserInfo_smallAvatar"); + content = ( + + ); + break; + } - { adminToolsContainer } + return ( +
+ + - { spinner } - ; + { content } + +
+ ); }; UserInfo.propTypes = { diff --git a/src/components/views/right_panel/VerificationPanel.js b/src/components/views/right_panel/VerificationPanel.js index 0d28e1568f..a66ecd34fb 100644 --- a/src/components/views/right_panel/VerificationPanel.js +++ b/src/components/views/right_panel/VerificationPanel.js @@ -1,5 +1,5 @@ /* -Copyright 2019 The Matrix.org Foundation C.I.C. +Copyright 2019, 2020 The Matrix.org Foundation C.I.C. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -15,8 +15,11 @@ limitations under the License. */ import React from 'react'; + import * as sdk from '../../../index'; import {verificationMethods} from 'matrix-js-sdk/src/crypto'; +import {_t} from "../../../languageHandler"; +import E2EIcon from "../rooms/E2EIcon"; export default class VerificationPanel extends React.PureComponent { constructor(props) { @@ -25,46 +28,81 @@ export default class VerificationPanel extends React.PureComponent { this._hasVerifier = !!props.request.verifier; } - render() { - return
+ renderQRPhase() { + const {member} = this.props; + // TODO change the button into a spinner when on click + const AccessibleButton = sdk.getComponent('elements.AccessibleButton'); + return
- { this.renderStatus() } +

Verify by scanning

+

{_t("Ask %(displayName)s to scan your code, or open your camera to scan theirs:", { + displayName: member.displayName || member.name || member.userId, + }, { + a: t => { t }, + })}

+
QR Code
-
; + +
+

Verify by emoji

+

{_t("If you can't scan the code above, verify by comparing unique emoji.")}

+ + {_t("Verify by emoji")} + +
+ ; } - renderStatus() { - const AccessibleButton = sdk.getComponent('elements.AccessibleButton'); - const Spinner = sdk.getComponent('elements.Spinner'); - const {request} = this.props; + renderVerifiedPhase() { + const {member} = this.props; - if (request.requested) { - return (

Waiting for {request.otherUserId} to accept ...

); - } else if (request.ready) { - const verifyButton = - Verify by emoji - ; - return (

{request.otherUserId} is ready, start {verifyButton}

); + const AccessibleButton = sdk.getComponent('elements.AccessibleButton'); + return ( +
+

Verified

+

{_t("You've successfully verified %(displayName)s!", { + displayName: member.displayName || member.name || member.userId, + })}

+ +

Verify all users in a room to ensure it's secure.

+ + {_t("Got it")} + +
+ ); + } + + render() { + const {member, request} = this.props; + + const displayName = member.displayName || member.name || member.userId; + + if (request.ready) { + return this.renderQRPhase(); } else if (request.started) { - if (this.state.sasWaitingForOtherParty) { - return

Waiting for {request.otherUserId} to confirm ...

; - } else if (this.state.sasEvent) { + if (this.state.sasEvent) { const VerificationShowSas = sdk.getComponent('views.verification.VerificationShowSas'); - return (
+ // TODO implement "mismatch" vs "cancelled" + return
+

Compare emoji

-
); +
; } else { return (

Setting up SAS verification...

); } } else if (request.done) { - return

verified {request.otherUserId}!!

; + return this.renderVerifiedPhase(); } else if (request.cancelled) { + // TODO check if this matches target + // TODO should this be a MODAL? return

cancelled by {request.cancellingUserId}!

; } + return null; } _startSAS = async () => { @@ -79,7 +117,6 @@ export default class VerificationPanel extends React.PureComponent { }; _onSasMatchesClick = () => { - this.setState({sasWaitingForOtherParty: true}); this.state.sasEvent.confirm(); }; @@ -106,7 +143,7 @@ export default class VerificationPanel extends React.PureComponent { request.verifier.removeListener('show_sas', this._onVerifierShowSas); } this._hasVerifier = !!request.verifier; - this.forceUpdate(); + this.forceUpdate(); // TODO fix this }; componentDidMount() { diff --git a/src/components/views/toasts/VerificationRequestToast.js b/src/components/views/toasts/VerificationRequestToast.js index 479a3e3f93..769e0d36d0 100644 --- a/src/components/views/toasts/VerificationRequestToast.js +++ b/src/components/views/toasts/VerificationRequestToast.js @@ -76,10 +76,14 @@ export default class VerificationRequestToast extends React.PureComponent { } try { await request.accept(); + const cli = MatrixClientPeg.get(); dis.dispatch({ action: "set_right_panel_phase", phase: RIGHT_PANEL_PHASES.EncryptionPanel, - refireParams: {verificationRequest: request}, + refireParams: { + verificationRequest: request, + member: cli.getUser(request.otherUserId), + }, }); } catch (err) { console.error(err.message); diff --git a/src/components/views/verification/VerificationShowSas.js b/src/components/views/verification/VerificationShowSas.js index 8f39457689..693a3769a0 100644 --- a/src/components/views/verification/VerificationShowSas.js +++ b/src/components/views/verification/VerificationShowSas.js @@ -18,6 +18,8 @@ import React from 'react'; import PropTypes from 'prop-types'; import * as sdk from '../../../index'; import { _t, _td } from '../../../languageHandler'; +import {PendingActionSpinner} from "../right_panel/EncryptionInfo"; +import AccessibleButton from "../elements/AccessibleButton"; function capFirst(s) { return s.charAt(0).toUpperCase() + s.slice(1); @@ -25,18 +27,26 @@ function capFirst(s) { export default class VerificationShowSas extends React.Component { static propTypes = { + displayName: PropTypes.string.isRequired, onDone: PropTypes.func.isRequired, onCancel: PropTypes.func.isRequired, sas: PropTypes.object.isRequired, + }; + + constructor(props) { + super(props); + + this.state = { + pending: false, + }; } - constructor() { - super(); - } + onMatchClick = () => { + this.setState({ pending: true }); + this.props.onDone(); + }; render() { - const DialogButtons = sdk.getComponent('views.elements.DialogButtons'); - let sasDisplay; let sasCaption; if (this.props.sas.emoji) { @@ -69,26 +79,33 @@ export default class VerificationShowSas extends React.Component { } else { return
{_t("Unable to find a supported verification method.")} - + + {_t('Cancel')} +
; } + let confirm; + if (this.state.pending) { + const {displayName} = this.props; + const text = _t("Waiting for %(displayName)s to verify…", {displayName}); + confirm = ; + } else { + confirm = + + {_t("They match")} + + + {_t("They don't match")} + + ; + } + return

{sasCaption}

-

{_t( - "For maximum security, we recommend you do this in person or use another " + - "trusted means of communication.", - )}

+

{_t("For ultimate security, do this in person or use another way to communicate.")}

{sasDisplay} - + {confirm}
; } } diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index c99b22f421..5b131b8750 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -451,7 +451,10 @@ "Verify this user by confirming the following number appears on their screen.": "Verify this user by confirming the following number appears on their screen.", "Unable to find a supported verification method.": "Unable to find a supported verification method.", "Cancel": "Cancel", - "For maximum security, we recommend you do this in person or use another trusted means of communication.": "For maximum security, we recommend you do this in person or use another trusted means of communication.", + "Waiting for %(displayName)s to verify…": "Waiting for %(displayName)s to verify…", + "They match": "They match", + "They don't match": "They don't match", + "For ultimate security, do this in person or use another way to communicate.": "For ultimate security, do this in person or use another way to communicate.", "Dog": "Dog", "Cat": "Cat", "Lion": "Lion", @@ -1124,12 +1127,13 @@ "URL previews are disabled by default for participants in this room.": "URL previews are disabled by default for participants in this room.", "In encrypted rooms, like this one, URL previews are disabled by default to ensure that your homeserver (where the previews are generated) cannot gather information about links you see in this room.": "In encrypted rooms, like this one, URL previews are disabled by default to ensure that your homeserver (where the previews are generated) cannot gather information about links you see in this room.", "When someone puts a URL in their message, a URL preview can be shown to give more information about that link such as the title, description, and an image from the website.": "When someone puts a URL in their message, a URL preview can be shown to give more information about that link such as the title, description, and an image from the website.", - "Verify User": "Verify User", - "For extra security, verify this user by checking a one-time code on both of your devices.": "For extra security, verify this user by checking a one-time code on both of your devices.", - "For maximum security, do this in person.": "For maximum security, do this in person.", + "Waiting for %(displayName)s to accept…": "Waiting for %(displayName)s to accept…", "Start Verification": "Start Verification", "Messages in this room are end-to-end encrypted.": "Messages in this room are end-to-end encrypted.", "Your messages are secured and only you and the recipient have the unique keys to unlock them.": "Your messages are secured and only you and the recipient have the unique keys to unlock them.", + "Verify User": "Verify User", + "For extra security, verify this user by checking a one-time code on both of your devices.": "For extra security, verify this user by checking a one-time code on both of your devices.", + "For maximum security, do this in person.": "For maximum security, do this in person.", "Members": "Members", "Files": "Files", "Trusted": "Trusted", @@ -1147,6 +1151,11 @@ "This client does not support end-to-end encryption.": "This client does not support end-to-end encryption.", "Messages in this room are not end-to-end encrypted.": "Messages in this room are not end-to-end encrypted.", "Security": "Security", + "Ask %(displayName)s to scan your code, or open your camera to scan theirs:": "Ask %(displayName)s to scan your code, or open your camera to scan theirs:", + "If you can't scan the code above, verify by comparing unique emoji.": "If you can't scan the code above, verify by comparing unique emoji.", + "Verify by emoji": "Verify by emoji", + "You've successfully verified %(displayName)s!": "You've successfully verified %(displayName)s!", + "Got it": "Got it", "Sunday": "Sunday", "Monday": "Monday", "Tuesday": "Tuesday", @@ -1426,6 +1435,7 @@ "Verify device": "Verify device", "Use Legacy Verification (for older clients)": "Use Legacy Verification (for older clients)", "Verify by comparing a short text string.": "Verify by comparing a short text string.", + "For maximum security, we recommend you do this in person or use another trusted means of communication.": "For maximum security, we recommend you do this in person or use another trusted means of communication.", "Begin Verifying": "Begin Verifying", "Waiting for partner to accept...": "Waiting for partner to accept...", "Nothing appearing? Not all clients support interactive verification yet. .": "Nothing appearing? Not all clients support interactive verification yet. .",