From 7c1943ef4ef216887049ae2d490b769655c6790f Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 9 Apr 2019 13:22:35 +0100 Subject: [PATCH] Key backup: Handle case where your onw sig is invalid Sometimes life is just like that --- src/components/views/settings/KeyBackupPanel.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/components/views/settings/KeyBackupPanel.js b/src/components/views/settings/KeyBackupPanel.js index cc1b3fd017..82d464c05e 100644 --- a/src/components/views/settings/KeyBackupPanel.js +++ b/src/components/views/settings/KeyBackupPanel.js @@ -227,11 +227,17 @@ export default class KeyBackupPanel extends React.PureComponent { "Backup has a signature from unknown device with ID %(deviceId)s.", { deviceId: sig.deviceId }, { verify }, ); - } else if (sig.device.getFingerprint() === MatrixClientPeg.get().getDeviceEd25519Key()) { + } else if (sig.device.getFingerprint() === MatrixClientPeg.get().getDeviceEd25519Key() && sig.valid) { sigStatus = _t( "Backup has a valid signature from this device", {}, { validity }, ); + } else if (sig.device.getFingerprint() === MatrixClientPeg.get().getDeviceEd25519Key() && !sig.valid) { + // it can happen... + sigStatus = _t( + "Backup has an invalid signature from this device", + {}, { validity }, + ); } else if (sig.valid && sig.device.isVerified()) { sigStatus = _t( "Backup has a valid signature from " +