From 7d55f3e75d55edef5a0303ab8c0f8909cce2d57e Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <richard@matrix.org>
Date: Thu, 1 Jun 2017 17:49:24 +0100
Subject: [PATCH] handle room key request cancellations

---
 src/KeyRequestHandler.js                | 55 ++++++++++++++++++++++---
 src/components/structures/MatrixChat.js |  3 ++
 2 files changed, 52 insertions(+), 6 deletions(-)

diff --git a/src/KeyRequestHandler.js b/src/KeyRequestHandler.js
index 90ff00d47e..fbb869d468 100644
--- a/src/KeyRequestHandler.js
+++ b/src/KeyRequestHandler.js
@@ -21,16 +21,18 @@ export default class KeyRequestHandler {
     constructor(matrixClient) {
         this._matrixClient = matrixClient;
 
-        this._isDialogOpen = false;
+        // the user/device for which we currently have a dialog open
+        this._currentUser = null;
+        this._currentDevice = null;
 
         // userId -> deviceId -> [keyRequest]
         this._pendingKeyRequests = {};
     }
 
-
     handleKeyRequest(keyRequest) {
         const userId = keyRequest.userId;
         const deviceId = keyRequest.deviceId;
+        const requestId = keyRequest.requestId;
 
         if (!this._pendingKeyRequests[userId]) {
             this._pendingKeyRequests[userId] = {};
@@ -38,9 +40,17 @@ export default class KeyRequestHandler {
         if (!this._pendingKeyRequests[userId][deviceId]) {
             this._pendingKeyRequests[userId][deviceId] = [];
         }
-        this._pendingKeyRequests[userId][deviceId].push(keyRequest);
 
-        if (this._isDialogOpen) {
+        // check if we already have this request
+        const requests = this._pendingKeyRequests[userId][deviceId];
+        if (requests.find((r) => r.requestId === requestId)) {
+            console.log("Already have this key request, ignoring");
+            return;
+        }
+
+        requests.push(keyRequest);
+
+        if (this._currentUser) {
             // ignore for now
             console.log("Key request, but we already have a dialog open");
             return;
@@ -49,6 +59,37 @@ export default class KeyRequestHandler {
         this._processNextRequest();
     }
 
+    handleKeyRequestCancellation(cancellation) {
+        // see if we can find the request in the queue
+        const userId = cancellation.userId;
+        const deviceId = cancellation.deviceId;
+        const requestId = cancellation.requestId;
+
+        if (userId === this._currentUser && deviceId === this._currentDevice) {
+            console.log(
+                "room key request cancellation for the user we currently have a"
+                + " dialog open for",
+            );
+            // TODO: update the dialog. For now, we just ignore the
+            // cancellation.
+            return;
+        }
+
+        if (!this._pendingKeyRequests[userId]) {
+            return;
+        }
+        const requests = this._pendingKeyRequests[userId][deviceId];
+        if (!requests) {
+            return;
+        }
+        const idx = requests.findIndex((r) => r.requestId === requestId);
+        if (idx < 0) {
+            return;
+        }
+        console.log("Forgetting room key request");
+        requests.splice(idx, 1);
+    }
+
     _processNextRequest() {
         const userId = Object.keys(this._pendingKeyRequests)[0];
         if (!userId) {
@@ -61,7 +102,8 @@ export default class KeyRequestHandler {
         console.log(`Starting KeyShareDialog for ${userId}:${deviceId}`);
 
         const finished = (r) => {
-            this._isDialogOpen = false;
+            this._currentUser = null;
+            this._currentDevice = null;
 
             if (r) {
                 for (const req of this._pendingKeyRequests[userId][deviceId]) {
@@ -83,7 +125,8 @@ export default class KeyRequestHandler {
             deviceId: deviceId,
             onFinished: finished,
         });
-        this._isDialogOpen = true;
+        this._currentUser = userId;
+        this._currentDevice = deviceId;
     }
 }
 
diff --git a/src/components/structures/MatrixChat.js b/src/components/structures/MatrixChat.js
index 544213edc6..afb3c57818 100644
--- a/src/components/structures/MatrixChat.js
+++ b/src/components/structures/MatrixChat.js
@@ -920,6 +920,9 @@ module.exports = React.createClass({
         cli.on("crypto.roomKeyRequest", (req) => {
             krh.handleKeyRequest(req);
         });
+        cli.on("crypto.roomKeyRequestCancellation", (req) => {
+            krh.handleKeyRequestCancellation(req);
+        });
     },
 
     showScreen: function(screen, params) {