OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Update `location.spec.ts` - use Cypress Testing Library (#10612) 

* Update location.spec.ts - use Cypress Testing Library

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Make the test id of location share option discoverable with findByTestId()

findByTestId seeks for data-testid, instead of data-test-id.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
pull/28788/head^2
Suguru Hirahara 2023-04-17 08:24:09 +00:00 committed by GitHub
parent 1d9df7ec51
commit 812564940d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cypress/e2e/location/location.spec.ts
View File

@ -23,11 +23,11 @@ describe("Location sharing", () => {
let homeserver: HomeserverInstance; let homeserver: HomeserverInstance;
const selectLocationShareTypeOption = (shareType: string): Chainable<JQuery> => { const selectLocationShareTypeOption = (shareType: string): Chainable<JQuery> => {
return cy.get(`[data-testid="share-location-option-${shareType}"]`); return cy.findByTestId(`share-location-option-${shareType}`);
}; };
const submitShareLocation = (): void => { const submitShareLocation = (): void => {
cy.get('[data-testid="location-picker-submit-button"]').click(); cy.findByRole("button", { name: "Share location" }).click();
}; };
beforeEach(() => { beforeEach(() => {
@ -53,7 +53,7 @@ describe("Location sharing", () => {
}); });
cy.openMessageComposerOptions().within(() => { cy.openMessageComposerOptions().within(() => {
cy.get('[aria-label="Location"]').click(); cy.findByRole("menuitem", { name: "Location" }).click();
}); });
selectLocationShareTypeOption("Pin").click(); selectLocationShareTypeOption("Pin").click();
@ -67,7 +67,7 @@ describe("Location sharing", () => {
// clicking location tile opens maximised map // clicking location tile opens maximised map
cy.get(".mx_LocationViewDialog_wrapper").should("exist"); cy.get(".mx_LocationViewDialog_wrapper").should("exist");
cy.get('[aria-label="Close dialog"]').click(); cy.closeDialog();
cy.get(".mx_Marker").should("exist"); cy.get(".mx_Marker").should("exist");
}); });