OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #6101 from jaiwanth-v/voice-message-destroy 

Destroy playback instance on voice message unmount
pull/21833/head
Michael Telatynski 2021-05-26 12:18:59 +01:00 committed by GitHub
parent 7ab31932ce a65299d8be
commit 84bdd61119
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/components/views/messages/MVoiceMessageBody.tsx
View File

@ -71,10 +71,14 @@ export default class MVoiceMessageBody extends React.PureComponent<IProps, IStat
// We should have a buffer to work with now: let's set it up // We should have a buffer to work with now: let's set it up
const playback = new Playback(buffer, waveform); const playback = new Playback(buffer, waveform);
this.setState({playback}); this.setState({ playback });
// Note: the RecordingPlayback component will handle preparing the Playback class for us. // Note: the RecordingPlayback component will handle preparing the Playback class for us.
} }
public componentWillUnmount() {
this.state.playback?.destroy();
}
public render() { public render() {
if (this.state.error) { if (this.state.error) {
// TODO: @@TR: Verify error state // TODO: @@TR: Verify error state