From 94ae06db4d964b22b568105f644d2ba57fdeef65 Mon Sep 17 00:00:00 2001
From: Travis Ralston <travpc@gmail.com>
Date: Fri, 6 Dec 2019 15:04:44 -0700
Subject: [PATCH] Fix cold open of the RightPanel directly to MemberInfo

This requires us to track some of the phase's state in the RightPanelStore, which is not great - trying to get it through the app is a bit difficult.
---
 src/components/structures/RightPanel.js | 16 +++++++++++-----
 src/stores/RightPanelStore.js           |  8 ++++++++
 2 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/src/components/structures/RightPanel.js b/src/components/structures/RightPanel.js
index 7497ecd8b9..1745c9d7dc 100644
--- a/src/components/structures/RightPanel.js
+++ b/src/components/structures/RightPanel.js
@@ -36,7 +36,7 @@ export default class RightPanel extends React.Component {
         return {
             roomId: PropTypes.string, // if showing panels for a given room, this is set
             groupId: PropTypes.string, // if showing panels for a given group, this is set
-            user: PropTypes.object,
+            user: PropTypes.object, // used if we know the user ahead of opening the panel
         };
     }
 
@@ -51,6 +51,7 @@ export default class RightPanel extends React.Component {
         this.state = {
             phase: this._getPhaseFromProps(),
             isUserPrivilegedInGroup: null,
+            member: this._getUserForPanel(),
         };
         this.onAction = this.onAction.bind(this);
         this.onRoomStateMember = this.onRoomStateMember.bind(this);
@@ -63,6 +64,14 @@ export default class RightPanel extends React.Component {
         }, 500);
     }
 
+    // Helper function to split out the logic for _getPhaseFromProps() and the constructor
+    // as both are called at the same time in the constructor.
+    _getUserForPanel() {
+        if (this.state && this.state.member) return this.state.member;
+        const lastParams = RightPanelStore.getSharedInstance().roomPanelPhaseParams;
+        return this.props.user || lastParams['member'];
+    }
+
     _getPhaseFromProps() {
         const rps = RightPanelStore.getSharedInstance();
         if (this.props.groupId) {
@@ -71,7 +80,7 @@ export default class RightPanel extends React.Component {
                 return RIGHT_PANEL_PHASES.GroupMemberList;
             }
             return rps.groupPanelPhase;
-        } else if (this.props.user) {
+        } else if (this._getUserForPanel()) {
             return RIGHT_PANEL_PHASES.RoomMemberInfo;
         } else {
             if (!RIGHT_PANEL_PHASES_NO_ARGS.includes(rps.roomPanelPhase)) {
@@ -87,9 +96,6 @@ export default class RightPanel extends React.Component {
         const cli = this.context.matrixClient;
         cli.on("RoomState.members", this.onRoomStateMember);
         this._initGroupStore(this.props.groupId);
-        if (this.props.user) {
-            this.setState({member: this.props.user});
-        }
     }
 
     componentWillUnmount() {
diff --git a/src/stores/RightPanelStore.js b/src/stores/RightPanelStore.js
index 39a65e2810..4542902ae8 100644
--- a/src/stores/RightPanelStore.js
+++ b/src/stores/RightPanelStore.js
@@ -28,6 +28,9 @@ const INITIAL_STATE = {
     // The last phase (screen) the right panel was showing
     lastRoomPhase: SettingsStore.getValue("lastRightPanelPhaseForRoom"),
     lastGroupPhase: SettingsStore.getValue("lastRightPanelPhaseForGroup"),
+
+    // Extra information about the last phase
+    lastRoomPhaseParams: {},
 };
 
 const GROUP_PHASES = Object.keys(RIGHT_PANEL_PHASES).filter(k => k.startsWith("Group"));
@@ -72,6 +75,10 @@ export default class RightPanelStore extends Store {
         return this.isOpenForGroup ? this.groupPanelPhase : null;
     }
 
+    get roomPanelPhaseParams(): any {
+        return this._state.lastRoomPhaseParams || {};
+    }
+
     _setState(newState) {
         this._state = Object.assign(this._state, newState);
 
@@ -142,6 +149,7 @@ export default class RightPanelStore extends Store {
                 this._setState({
                     lastRoomPhase: targetPhase,
                     showRoomPanel: true,
+                    lastRoomPhaseParams: payload.refireParams || {},
                 });
             }
         }