Merge pull request #3665 from matrix-org/travis/fix-flashing

Hide tooltips with CSS when they aren't visible
pull/21833/head
Travis Ralston 2019-11-25 09:13:43 -07:00 committed by GitHub
commit 98693d2dbc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions

View File

@ -100,7 +100,9 @@ module.exports = createReactClass({
const parent = ReactDOM.findDOMNode(this).parentNode; const parent = ReactDOM.findDOMNode(this).parentNode;
let style = {}; let style = {};
style = this._updatePosition(style); style = this._updatePosition(style);
style.display = "block"; // Hide the entire container when not visible. This prevents flashing of the tooltip
// if it is not meant to be visible on first mount.
style.display = this.props.visible ? "block" : "none";
const tooltipClasses = classNames("mx_Tooltip", this.props.tooltipClassName, { const tooltipClasses = classNames("mx_Tooltip", this.props.tooltipClassName, {
"mx_Tooltip_visible": this.props.visible, "mx_Tooltip_visible": this.props.visible,