From a6cefb83f86f4fe0050e1af18e81d5c631b97024 Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Mon, 22 Jan 2018 16:41:32 +0000
Subject: [PATCH] basic error handling for malformed quotes

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
---
 src/components/views/elements/Quote.js | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/components/views/elements/Quote.js b/src/components/views/elements/Quote.js
index 55b59a5789..0a186b3ca6 100644
--- a/src/components/views/elements/Quote.js
+++ b/src/components/views/elements/Quote.js
@@ -53,8 +53,8 @@ export default class Quote extends React.Component {
             events: [],
             // Whether the top (oldest) event should be shown or spoilered
             show: true,
-            // Whether an error was encountered fetching another older event, show if it does
-            err: null,
+            // Whether an error was encountered fetching nested older event, show node if it does
+            err: false,
         };
 
         this.onQuoteClick = this.onQuoteClick.bind(this);
@@ -124,10 +124,16 @@ export default class Quote extends React.Component {
     // addRichQuote(roomId, eventId) {
     addRichQuote(href) {
         const {roomIdentifier, eventId} = this.parseUrl(href);
-        if (!roomIdentifier || !eventId) return;
+        if (!roomIdentifier || !eventId) {
+            this.setState({ err: true });
+            return;
+        }
 
         const room = this.getRoom(roomIdentifier);
-        if (!room) return;
+        if (!room) {
+            this.setState({ err: true });
+            return;
+        }
 
         this.getEvent(room, eventId, false);
     }