diff --git a/src/components/views/rooms/SendMessageComposer.tsx b/src/components/views/rooms/SendMessageComposer.tsx index d12a84e0c2..f9544cb54d 100644 --- a/src/components/views/rooms/SendMessageComposer.tsx +++ b/src/components/views/rooms/SendMessageComposer.tsx @@ -95,16 +95,9 @@ export function attachMentions( const userMentions = new Set(); let roomMention = false; - // If there's a reply, initialize the mentioned users as the sender of that - // event + any mentioned users in that event. + // If there's a reply, initialize the mentioned users as the sender of that event. if (replyToEvent) { userMentions.add(replyToEvent.sender!.userId); - // TODO What do we do if the reply event *doeesn't* have this property? - // Try to fish out replies from the contents? - const userIds = replyToEvent.getContent()["m.mentions"]?.user_ids; - if (Array.isArray(userIds)) { - userIds.forEach((userId) => userMentions.add(userId)); - } } // If user provided content is available, check to see if any users are mentioned. diff --git a/test/unit-tests/components/views/rooms/EditMessageComposer-test.tsx b/test/unit-tests/components/views/rooms/EditMessageComposer-test.tsx index cdc961f73c..fc50d84981 100644 --- a/test/unit-tests/components/views/rooms/EditMessageComposer-test.tsx +++ b/test/unit-tests/components/views/rooms/EditMessageComposer-test.tsx @@ -432,8 +432,6 @@ describe("", () => { user_ids: [ // sender of event we replied to originalEvent.getSender()!, - // mentions from this event - "@bob:server.org", ], }, }, diff --git a/test/unit-tests/components/views/rooms/SendMessageComposer-test.tsx b/test/unit-tests/components/views/rooms/SendMessageComposer-test.tsx index ad0ec2afdf..b9bf9bf7ee 100644 --- a/test/unit-tests/components/views/rooms/SendMessageComposer-test.tsx +++ b/test/unit-tests/components/views/rooms/SendMessageComposer-test.tsx @@ -195,7 +195,7 @@ describe("", () => { "m.mentions": { user_ids: ["@bob:test"] }, }); - // It also adds any other mentioned users, but removes yourself. + // It no longer adds any other mentioned users replyToEvent = mkEvent({ type: "m.room.message", user: "@bob:test", @@ -206,7 +206,7 @@ describe("", () => { content = {}; attachMentions("@alice:test", content, model, replyToEvent); expect(content).toEqual({ - "m.mentions": { user_ids: ["@bob:test", "@charlie:test"] }, + "m.mentions": { user_ids: ["@bob:test"] }, }); });