From 1bada070ca5e4af4c9c91c5fbe4785d0bc8af42b Mon Sep 17 00:00:00 2001 From: David Baker Date: Wed, 18 Oct 2017 19:36:07 +0100 Subject: [PATCH] Make gen-i18n support 'HTML' Where by 'HTML' I mean just run the same regex as riot does over some text. Also make it walk multiple paths. This mostly means it can be used for riot-web. --- scripts/gen-i18n.js | 45 +++++++++++++++++++++++++++++++++++++++------ 1 file changed, 39 insertions(+), 6 deletions(-) diff --git a/scripts/gen-i18n.js b/scripts/gen-i18n.js index 3ce5aeb312..c6e162cfb0 100644 --- a/scripts/gen-i18n.js +++ b/scripts/gen-i18n.js @@ -34,6 +34,13 @@ const TRANSLATIONS_FUNCS = ['_t', '_td', '_tJsx']; const INPUT_TRANSLATIONS_FILE = 'src/i18n/strings/en_EN.json'; +// NB. The sync version of walk is broken for single files so we walk +// all of res rather than just res/home.html. +// https://git.daplie.com/Daplie/node-walk/merge_requests/1 fixes it, +// or if we get bored waiting for it to be merged, we could switch +// to a project that's actively maintained. +const SEARCH_PATHS = ['src', 'res']; + const FLOW_PARSER_OPTS = { esproposal_class_instance_fields: true, esproposal_class_static_fields: true, @@ -64,7 +71,7 @@ function getTKey(arg) { return null; } -function getTranslations(file) { +function getTranslationsJs(file) { const tree = flowParser.parse(fs.readFileSync(file, { encoding: 'utf8' }), FLOW_PARSER_OPTS); const trs = new Set(); @@ -106,6 +113,20 @@ function getTranslations(file) { return trs; } +function getTranslationsOther(file) { + const contents = fs.readFileSync(file, { encoding: 'utf8' }); + + const trs = new Set(); + + // Taken from riot-web src/components/structures/HomePage.js + const translationsRegex = /_t\(['"]([\s\S]*?)['"]\)/mg; + let matches; + while (matches = translationsRegex.exec(contents)) { + trs.add(matches[1]); + } + return trs; +} + // gather en_EN plural strings from the input translations file: // the en_EN strings are all in the source with the exception of // pluralised strings, which we need to pull in from elsewhere. @@ -123,20 +144,32 @@ for (const key of Object.keys(inputTranslationsRaw)) { const translatables = new Set(); -walk.walkSync("src", { +const walkOpts = { listeners: { file: function(root, fileStats, next) { - if (!fileStats.name.endsWith('.js')) return; - const fullPath = path.join(root, fileStats.name); - const trs = getTranslations(fullPath); + + let ltrs; + if (fileStats.name.endsWith('.js')) { + trs = getTranslationsJs(fullPath); + } else if (fileStats.name.endsWith('.html')) { + trs = getTranslationsOther(fullPath); + } else { + return; + } console.log(`${fullPath} (${trs.size} strings)`); for (const tr of trs.values()) { translatables.add(tr); } }, } -}); +}; + +for (const path of SEARCH_PATHS) { + if (fs.existsSync(path)) { + walk.walkSync(path, walkOpts); + } +} const trObj = {}; for (const tr of translatables) {