OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix headings margin on security user settings tab (#8826) 

* Apply kind=link to 'Learn more' link on security user settings tab

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove specific margin setting from heading on security user settings tab

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
pull/28788/head^2
Suguru Hirahara 2022-07-06 10:48:52 +00:00 committed by GitHub
parent 2ebb5eb957
commit afa8b01601
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
res/css/views/settings/tabs/_SettingsTab.scss
View File

@ -92,12 +92,6 @@ limitations under the License.
} }
} }
.mx_SettingsTab_linkBtn {
cursor: pointer;
color: $accent;
word-break: break-all;
}
.mx_SettingsTab_toggleWithDescription { .mx_SettingsTab_toggleWithDescription {
margin-top: $spacing-24; margin-top: $spacing-24;
} }

3
res/css/views/settings/tabs/user/_SecurityUserSettingsTab.scss
View File

@ -27,9 +27,6 @@ limitations under the License.
} }
.mx_SecurityUserSettingsTab { .mx_SecurityUserSettingsTab {
.mx_SettingsTab_heading {
margin-bottom: 22px;
}
.mx_SettingsTab_section { .mx_SettingsTab_section {
.mx_AccessibleButton_kind_link { .mx_AccessibleButton_kind_link {
font-size: inherit; font-size: inherit;

11
src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx
View File

@ -306,11 +306,12 @@ export default class SecurityUserSettingsTab extends React.Component<IProps, ISt
{ _t("Share anonymous data to help us identify issues. Nothing personal. " + { _t("Share anonymous data to help us identify issues. Nothing personal. " +
"No third parties.") } "No third parties.") }
</p> </p>
<p> <AccessibleButton
<AccessibleButton className="mx_SettingsTab_linkBtn" onClick={onClickAnalyticsLearnMore}> kind="link"
{ _t("Learn more") } onClick={onClickAnalyticsLearnMore}
</AccessibleButton> >
</p> { _t("Learn more") }
</AccessibleButton>
</div> </div>
{ PosthogAnalytics.instance.isEnabled() && ( { PosthogAnalytics.instance.isEnabled() && (
<SettingsFlag <SettingsFlag