diff --git a/playwright/e2e/login/overwrite_login.spec.ts b/playwright/e2e/login/overwrite_login.spec.ts index b047cfa3dd..986fbfc516 100644 --- a/playwright/e2e/login/overwrite_login.spec.ts +++ b/playwright/e2e/login/overwrite_login.spec.ts @@ -47,7 +47,6 @@ test.describe("Overwrite login action", () => { }, clientCredentials); // It should be now another user!! - const newUserMenu = await app.openUserMenu(); - await expect(newUserMenu.getByText(bobRegister.userId)).toBeVisible(); + await expect(page.getByText("Welcome BOB")).toBeVisible(); }); }); diff --git a/playwright/e2e/one-to-one-chat/one-to-one-chat.spec.ts b/playwright/e2e/one-to-one-chat/one-to-one-chat.spec.ts index 39b30fbab5..287ac77cd4 100644 --- a/playwright/e2e/one-to-one-chat/one-to-one-chat.spec.ts +++ b/playwright/e2e/one-to-one-chat/one-to-one-chat.spec.ts @@ -45,6 +45,7 @@ test.describe("1:1 chat room", () => { await expect( page.getByRole("group", { name: "Rooms" }).locator(".mx_RoomTile").getByText(user2.displayName), ).not.toBeVisible(); + await page.waitForTimeout(500); // avoid race condition with routing // open new 1:1 chat room await page.goto(`/#/user/${user2.userId}?action=chat`); diff --git a/playwright/e2e/user-onboarding/user-onboarding-new.spec.ts b/playwright/e2e/user-onboarding/user-onboarding-new.spec.ts index 46bca0b78b..09a140d441 100644 --- a/playwright/e2e/user-onboarding/user-onboarding-new.spec.ts +++ b/playwright/e2e/user-onboarding/user-onboarding-new.spec.ts @@ -45,7 +45,17 @@ test.describe("User Onboarding (new user)", () => { await expect( page.getByRole("dialog").getByRole("heading", { level: 1, name: "Download Element" }), ).toBeVisible(); - await expect(page.locator(".mx_Dialog")).toMatchScreenshot(); + await expect(page.locator(".mx_Dialog")).toMatchScreenshot( + "User-Onboarding-new-user-app-download-dialog-1.png", + { + // Set a constant bg behind the modal to ensure screenshot stability + css: ` + .mx_AppDownloadDialog_wrapper { + background: black; + } + `, + }, + ); }); test("using find friends action should increase progress", async ({ page, homeserver }) => { diff --git a/playwright/pages/settings.ts b/playwright/pages/settings.ts index 916ce26e03..c0efb6770c 100644 --- a/playwright/pages/settings.ts +++ b/playwright/pages/settings.ts @@ -25,8 +25,9 @@ export class Settings { * Open the top left user menu, returning a Locator to the resulting context menu. */ public async openUserMenu(): Promise { - await this.page.getByRole("button", { name: "User menu" }).click(); const locator = this.page.locator(".mx_ContextualMenu"); + if (await locator.locator(".mx_UserMenu_contextMenu_header").isVisible()) return locator; + await this.page.getByRole("button", { name: "User menu" }).click(); await locator.waitFor(); return locator; } diff --git a/playwright/snapshots/user-onboarding/user-onboarding-new.spec.ts/User-Onboarding-new-user-app-download-dialog-1-linux.png b/playwright/snapshots/user-onboarding/user-onboarding-new.spec.ts/User-Onboarding-new-user-app-download-dialog-1-linux.png index 589cb34cb4..0c7fc94a0e 100644 Binary files a/playwright/snapshots/user-onboarding/user-onboarding-new.spec.ts/User-Onboarding-new-user-app-download-dialog-1-linux.png and b/playwright/snapshots/user-onboarding/user-onboarding-new.spec.ts/User-Onboarding-new-user-app-download-dialog-1-linux.png differ