diff --git a/cypress/e2e/settings/general-user-settings-tab.spec.ts b/cypress/e2e/settings/general-user-settings-tab.spec.ts index 2c12f3cb75..2879d6d930 100644 --- a/cypress/e2e/settings/general-user-settings-tab.spec.ts +++ b/cypress/e2e/settings/general-user-settings-tab.spec.ts @@ -53,7 +53,7 @@ describe("General user settings tab", () => { cy.findByTestId("mx_GeneralUserSettingsTab").within(() => { // Assert that the top heading is rendered - cy.findByTestId("general").should("have.text", "General").should("be.visible"); + cy.findByText("General").should("be.visible"); cy.get(".mx_ProfileSettings_profile") .scrollIntoView() diff --git a/res/css/views/settings/_ProfileSettings.pcss b/res/css/views/settings/_ProfileSettings.pcss index 4dc8168945..0b4c68120c 100644 --- a/res/css/views/settings/_ProfileSettings.pcss +++ b/res/css/views/settings/_ProfileSettings.pcss @@ -15,7 +15,6 @@ limitations under the License. */ .mx_ProfileSettings { - margin-inline-end: var(--SettingsTab_fullWidthField-margin-inline-end); border-bottom: 1px solid $quinary-content; .mx_ProfileSettings_avatarUpload { @@ -29,8 +28,8 @@ limitations under the License. flex-grow: 1; margin-inline-end: 54px; - .mx_Field:first-child { - margin-top: 0; + .mx_Field { + margin-top: $spacing-8; } .mx_ProfileSettings_profile_controls_topic { diff --git a/src/components/views/settings/ProfileSettings.tsx b/src/components/views/settings/ProfileSettings.tsx index 8f962ba38e..529bb86a78 100644 --- a/src/components/views/settings/ProfileSettings.tsx +++ b/src/components/views/settings/ProfileSettings.tsx @@ -29,6 +29,7 @@ import AvatarSetting from "./AvatarSetting"; import UserIdentifierCustomisations from "../../../customisations/UserIdentifier"; import { chromeFileInputFix } from "../../../utils/BrowserWorkarounds"; import PosthogTrackers from "../../../PosthogTrackers"; +import { SettingsSubsectionHeading } from "./shared/SettingsSubsectionHeading"; interface IState { originalDisplayName: string; @@ -183,7 +184,7 @@ export default class ProfileSettings extends React.Component<{}, IState> { />