From bb91df1d3c205e99ebec45dd32be786e8249fe07 Mon Sep 17 00:00:00 2001
From: Charly Nguyen <1422657+charlynguyen@users.noreply.github.com>
Date: Mon, 11 Sep 2023 15:33:27 +0200
Subject: [PATCH] Avoid rendering view-message link in RoomKnocksBar
 unnecessarily (#11598)

Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
---
 src/components/views/rooms/RoomKnocksBar.tsx  |  2 +-
 .../views/rooms/RoomKnocksBar-test.tsx        | 29 ++++++++++++++-----
 2 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/src/components/views/rooms/RoomKnocksBar.tsx b/src/components/views/rooms/RoomKnocksBar.tsx
index 4928e3cf30..f24db6ed2e 100644
--- a/src/components/views/rooms/RoomKnocksBar.tsx
+++ b/src/components/views/rooms/RoomKnocksBar.tsx
@@ -112,7 +112,7 @@ export const RoomKnocksBar: VFC<{ room: Room }> = ({ room }) => {
                 </>
             );
             names = `${knockMembers[0].name} (${knockMembers[0].userId})`;
-            link = (
+            link = knockMembers[0].events.member?.getContent().reason && (
                 <AccessibleButton
                     className="mx_RoomKnocksBar_link"
                     element="a"
diff --git a/test/components/views/rooms/RoomKnocksBar-test.tsx b/test/components/views/rooms/RoomKnocksBar-test.tsx
index 30141077e8..1f5a89036b 100644
--- a/test/components/views/rooms/RoomKnocksBar-test.tsx
+++ b/test/components/views/rooms/RoomKnocksBar-test.tsx
@@ -165,13 +165,28 @@ describe("RoomKnocksBar", () => {
                 expect(screen.getByRole("paragraph")).toHaveTextContent(`${bob.name} (${bob.userId})`);
             });
 
-            it("renders a link to open the room settings people tab", () => {
-                getComponent(room);
-                fireEvent.click(getButton("View message"));
-                expect(dis.dispatch).toHaveBeenCalledWith({
-                    action: "open_room_settings",
-                    initial_tab_id: RoomSettingsTab.People,
-                    room_id: roomId,
+            describe("when a knock reason is not provided", () => {
+                it("does not render a link to open the room settings people tab", () => {
+                    getComponent(room);
+                    expect(screen.queryByRole("button", { name: "View message" })).not.toBeInTheDocument();
+                });
+            });
+
+            describe("when a knock reason is provided", () => {
+                it("renders a link to open the room settings people tab", () => {
+                    bob.setMembershipEvent(
+                        new MatrixEvent({
+                            content: { displayname: "Bob", membership: "knock", reason: "some reason" },
+                            type: EventType.RoomMember,
+                        }),
+                    );
+                    getComponent(room);
+                    fireEvent.click(getButton("View message"));
+                    expect(dis.dispatch).toHaveBeenCalledWith({
+                        action: "open_room_settings",
+                        initial_tab_id: RoomSettingsTab.People,
+                        room_id: roomId,
+                    });
                 });
             });