Make label clickable on narrow mode context menu

res/css/views/rooms/_MessageComposer.scss

@@ -186,11 +186,14 @@ limitations under the License.
 }
 
 .mx_MessageComposer_button {
+    --size: 26px;
     position: relative;
     margin-right: 6px;
     cursor: pointer;
-    height: 26px;
-    width: 26px;
+    height: var(--size);
+    line-height: var(--size);
+    width: auto;
+    padding-left: calc(var(--size) + 5px);
     border-radius: 100%;
 
     &::before {
@@ -207,8 +210,21 @@ limitations under the License.
         mask-position: center;
     }
 
+    &::after {
+        content: '';
+        position: absolute;
+        left: 0;
+        top: 0;
+        z-index: 0;
+        width: var(--size);
+        height: var(--size);
+        border-radius: 50%;
+    }
+
     &:hover {
-        background: rgba($accent-color, 0.1);
+        &::after {
+            background: rgba($accent-color, 0.1);
+        }
 
         &::before {
             background-color: $accent-color;

src/components/views/elements/AccessibleTooltipButton.tsx

@@ -25,6 +25,7 @@ import { replaceableComponent } from "../../../utils/replaceableComponent";
 interface ITooltipProps extends React.ComponentProps<typeof AccessibleButton> {
     title: string;
     tooltip?: React.ReactNode;
+    label?: React.ReactNode;
     tooltipClassName?: string;
     forceHide?: boolean;
     yOffset?: number;
@@ -84,7 +85,8 @@ export default class AccessibleTooltipButton extends React.PureComponent<IToolti
                 aria-label={title}
             >
                 { children }
-                { tip }
+                { this.props.label }
+                { (tooltip || title) && tip }
             </AccessibleButton>
         );
     }

src/components/views/rooms/MessageComposer.tsx

@@ -81,7 +81,13 @@ function SendButton(props: ISendButtonProps) {
     );
 }
 
-const EmojiButton = ({ addEmoji, menuPosition }) => {
+interface IEmojiButtonProps {
+    addEmoji: (unicode: string) => boolean;
+    menuPosition: any; // TODO: Types
+    narrowMode: boolean;
+}
+
+const EmojiButton: React.FC<IEmojiButtonProps> = ({ addEmoji, menuPosition, narrowMode }) => {
     const [menuDisplayed, button, openMenu, closeMenu] = useContextMenu();
 
     let contextMenu;
@@ -103,12 +109,11 @@ const EmojiButton = ({ addEmoji, menuPosition }) => {
     // TODO: replace ContextMenuTooltipButton with a unified representation of
     // the header buttons and the right panel buttons
     return <React.Fragment>
-        <ContextMenuTooltipButton
+        <AccessibleTooltipButton
             className={className}
             onClick={openMenu}
-            isExpanded={menuDisplayed}
-            title={_t('Emoji picker')}
-            inputRef={button}
+            title={!narrowMode && _t('Emoji picker')}
+            label={narrowMode && _t("Send an emoji")}
         />
 
         { contextMenu }
@@ -364,11 +369,12 @@ export default class MessageComposer extends React.Component<IProps, IState> {
         }
     };
 
-    private addEmoji(emoji: string) {
+    private addEmoji(emoji: string): boolean {
         dis.dispatch<ComposerInsertPayload>({
             action: Action.ComposerInsert,
             text: emoji,
         });
+        return true;
     }
 
     private sendMessage = async () => {
@@ -424,32 +430,34 @@ export default class MessageComposer extends React.Component<IProps, IState> {
     };
 
     private renderButtons(menuPosition): JSX.Element | JSX.Element[] {
-        const buttons = new Map<string, JSX.Element>();
+        const buttons: JSX.Element[] = [];
         if (!this.state.haveRecording) {
-            buttons.set(
-                _t("Send a file"),
+            buttons.push(
                 <UploadButton key="controls_upload" roomId={this.props.room.roomId} />,
             );
-            buttons.set(
-                _t("Add emoji"),
-                <EmojiButton key="emoji_button" addEmoji={this.addEmoji} menuPosition={menuPosition} />,
+            buttons.push(
+                <EmojiButton key="emoji_button" addEmoji={this.addEmoji} menuPosition={menuPosition} narrowMode={this.state.narrowMode} />,
             );
         }
         if (this.shouldShowStickerPicker()) {
-            buttons.set(
-                _t("Send a sticker"),
+            let title;
+            if (!this.state.narrowMode) {
+                title = this.state.showStickers ? _t("Hide Stickers") : _t("Show Stickers");
+            }
+
+            buttons.push(
                 <AccessibleTooltipButton
                     id='stickersButton'
                     key="controls_stickers"
                     className="mx_MessageComposer_button mx_MessageComposer_stickers"
                     onClick={() => this.showStickers(!this.state.showStickers)}
-                    title={this.state.showStickers ? _t("Hide Stickers") : _t("Show Stickers")}
+                    title={title}
+                    label={this.state.narrowMode && _t("Send a sticker")}
                 />,
             );
         }
         if (!this.state.haveRecording && !this.state.narrowMode) {
-            buttons.set(
-                _t("Send a voice message"),
+            buttons.push(
                 <AccessibleTooltipButton
                     className="mx_MessageComposer_button mx_MessageComposer_voiceMessage"
                     onClick={() => this.voiceRecordingButton?.onRecordStartEndClick()}
@@ -458,9 +466,8 @@ export default class MessageComposer extends React.Component<IProps, IState> {
             );
         }
 
-        const buttonsArray = Array.from(buttons.values());
         if (!this.state.narrowMode) {
-            return buttonsArray;
+            return buttons;
         } else {
             const classnames = classNames({
                 mx_MessageComposer_button: true,
@@ -469,7 +476,7 @@ export default class MessageComposer extends React.Component<IProps, IState> {
             });
 
             return <>
-                { buttonsArray[0] }
+                { buttons[0] }
                 <AccessibleTooltipButton
                     className={classnames}
                     onClick={this.toggleButtonMenu}
@@ -486,10 +493,9 @@ export default class MessageComposer extends React.Component<IProps, IState> {
                         menuWidth={150}
                         wrapperClassName="mx_MessageComposer_Menu"
                     >
-                        { Array.from(buttons).slice(1).map(([label, button]) => (
-                            <MenuItem className="mx_CallContextMenu_item" key={label} onClick={this.toggleButtonMenu}>
+                        { buttons.slice(1).map((button, index) => (
+                            <MenuItem className="mx_CallContextMenu_item" key={index} onClick={this.toggleButtonMenu}>
                                 { button }
-                                { label }
                             </MenuItem>
                         )) }
                     </ContextMenu>

src/i18n/strings/en_EN.json

@@ -1559,6 +1559,7 @@
     "%(userName)s (power %(powerLevelNumber)s)": "%(userName)s (power %(powerLevelNumber)s)",
     "Send message": "Send message",
     "Emoji picker": "Emoji picker",
+    "Send an emoji": "Send an emoji",
     "Upload file": "Upload file",
     "Reply to encrypted thread…": "Reply to encrypted thread…",
     "Reply to thread…": "Reply to thread…",
@@ -1566,12 +1567,9 @@
     "Send a reply…": "Send a reply…",
     "Send an encrypted message…": "Send an encrypted message…",
     "Send a message…": "Send a message…",
-    "Send a file": "Send a file",
-    "Add emoji": "Add emoji",
-    "Send a sticker": "Send a sticker",
     "Hide Stickers": "Hide Stickers",
     "Show Stickers": "Show Stickers",
-    "Send a voice message": "Send a voice message",
+    "Send an sticker": "Send an sticker",
     "Send voice message": "Send voice message",
     "More options": "More options",
     "The conversation continues here.": "The conversation continues here.",