Fix broken "Go to Home View" shortcut on macOS

The previous shortcut CMD+OPT+H is already bound by the system (hide other
windows) and cannot be overridden. This commit changes the shortcut to
CTRL+SHIFT+H on macOS while keeping CTRL+ALT+H on other platforms.

Note that both CTRL+OPT+H (hide cursor) and CTRL+H (delete previous character)
are bound by the system as well and wouldn't have worked as a replacement.

Fixes: vector-im/element-web#16692

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
pull/21833/head
Johannes Marbach 2021-03-30 20:00:12 +02:00
parent b089f3d2f9
commit c7fcf2a936
2 changed files with 4 additions and 4 deletions

View File

@ -360,11 +360,11 @@ const navigationBindings = (): KeyBinding<NavigationAction>[] => {
action: NavigationAction.GoToHome, action: NavigationAction.GoToHome,
keyCombo: { keyCombo: {
key: Key.H, key: Key.H,
ctrlOrCmd: true, ctrlKey: true,
altKey: true, altKey: !isMac,
shiftKey: isMac,
}, },
}, },
{ {
action: NavigationAction.SelectPrevRoom, action: NavigationAction.SelectPrevRoom,
keyCombo: { keyCombo: {

View File

@ -265,7 +265,7 @@ const shortcuts: Record<Categories, IShortcut[]> = {
description: _td("Toggle this dialog"), description: _td("Toggle this dialog"),
}, { }, {
keybinds: [{ keybinds: [{
modifiers: [CMD_OR_CTRL, Modifiers.ALT], modifiers: [Modifiers.CONTROL, isMac ? Modifiers.SHIFT : Modifiers.ALT],
key: Key.H, key: Key.H,
}], }],
description: _td("Go to Home View"), description: _td("Go to Home View"),