From 76416ec7b9d9a33aa21ff418ccc3419f177346c2 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Tue, 25 Jun 2024 14:31:11 +0100 Subject: [PATCH 1/2] Remove redundant reusable workflow input Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- .github/workflows/release.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index a9b38d9a4e..1c7924a2a9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -20,7 +20,6 @@ jobs: GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }} with: final: ${{ inputs.mode == 'final' }} - include-changes: matrix-react-sdk gpg-fingerprint: ${{ vars.GPG_FINGERPRINT }} asset-path: dist/*.tar.gz expected-asset-count: 3 From 0845c515c40a1206d2fe61408fce0559fd2c8976 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Tue, 25 Jun 2024 14:31:30 +0100 Subject: [PATCH 2/2] Use workflow_dispatch over repository_dispatch as it lets us specify branch Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- .github/workflows/release.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1c7924a2a9..3bb1418986 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -30,11 +30,13 @@ jobs: runs-on: ubuntu-latest steps: - name: Notify element-desktop repo that element-web release has completed to re-trigger release-drafter - uses: peter-evans/repository-dispatch@ff45666b9427631e3450c54a1bcbee4d9ff4d7c0 # v3 + uses: benc-uk/workflow-dispatch@25b02cc069be46d637e8fe2f1e8484008e9e9609 # v1 with: - token: ${{ secrets.ELEMENT_BOT_TOKEN }} - repository: element-hq/element-desktop - event-type: upstream-release-notify + workflow: release-drafter.yml + repo: element-hq/element-desktop + ref: staging + # Required when using the `repo` option. Either a PAT or a token generated from the GitHub app or CLI + token: "${{ secrets.ELEMENT_BOT_TOKEN }}" check: name: Post release checks